New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show list of contributors since previous release #31

Merged
merged 3 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 22, 2017

These changes implement two routines which fulfill the desired feature
mentioned in #11: one to print the list of recent contributors
(show_recent_contributors()) and one to obtain the list of recent
contributors from the relevant version control system
(get_recent_contributors()). The get_recent_contributors() method
is only a stub and needs to be overridden by the appropriate mixin for
the given version control system. A concrete implementation of this
method will be submitted in a separate PR to the Module::Release::Git
repository.

Show list of contributors since previous release
These changes implement two routines which fulfill the desired feature
mentioned in #11: one to print the list of recent contributors
(`show_recent_contributors()`) and one to obtain the list of recent
contributors from the relevant version control system
(`get_recent_contributors()`).  The `get_recent_contributors()` method
is only a stub and needs to be overridden by the appropriate mixin for
the given version control system.  A concrete implementation of this
method will be submitted in a separate PR to the `Module::Release::Git`
repository.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 22, 2017

Coverage Status

Coverage increased (+0.5%) to 67.475% when pulling 1ca4e7d on paultcochrane:pr/show-recent-contributors into 6532dbf on briandfoy:master.

coveralls commented Oct 22, 2017

Coverage Status

Coverage increased (+0.5%) to 67.475% when pulling 1ca4e7d on paultcochrane:pr/show-recent-contributors into 6532dbf on briandfoy:master.

briandfoy added some commits Nov 13, 2017

@briandfoy briandfoy merged commit 487c5bd into briandfoy:master Nov 13, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@briandfoy

This comment has been minimized.

Show comment
Hide comment
@briandfoy

briandfoy Nov 13, 2017

Owner

I merged this but made a change in show_contributors to use can to look for get_contributors. This way we don't need the stub and Try::Tiny and everything else that follows from that.

Thanks!

Owner

briandfoy commented Nov 13, 2017

I merged this but made a change in show_contributors to use can to look for get_contributors. This way we don't need the stub and Try::Tiny and everything else that follows from that.

Thanks!

@briandfoy briandfoy self-requested a review Nov 13, 2017

@briandfoy briandfoy self-assigned this Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment