New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for fetch_oui_from_custom #22

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@openstrike
Contributor

openstrike commented Jul 7, 2017

As discussed in issue #19 here are some tests for fetch_oui_from_custom. I've based them on the existing tests of other methods so you should hopefully find the structure familiar.

Also, I've made one small change to the method itself such that it now calls _fetch_oui_from_url() internally rather than just the plain ua->get. This means that it benefits from all the same error handling as the other data-retrieval methods.

I hope you find these useful. Sorry for the delay in getting them to you.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 7, 2017

Coverage Status

Coverage increased (+6.2%) to 90.0% when pulling b4eb092 on openstrike:coverage into 8ac7917 on briandfoy:master.

coveralls commented Jul 7, 2017

Coverage Status

Coverage increased (+6.2%) to 90.0% when pulling b4eb092 on openstrike:coverage into 8ac7917 on briandfoy:master.

@briandfoy briandfoy merged commit b53c5ae into briandfoy:master Jul 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@briandfoy

This comment has been minimized.

Show comment
Hide comment
@briandfoy

briandfoy Jul 7, 2017

Owner

Good work! Thanks,

Owner

briandfoy commented Jul 7, 2017

Good work! Thanks,

@briandfoy briandfoy self-requested a review Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment