New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file_mode_h* tests for win32 #13

Merged
merged 1 commit into from Jun 24, 2015

Conversation

Projects
None yet
2 participants
@rjbs
Contributor

rjbs commented Jun 24, 2015

On Win32, when we skip the test, we should expect a lot less
output, of course. Further, skipped tests are "ok" and not
"not ok".

fix file_mode_h* tests for win32
On Win32, when we skip the test, we should expect a lot less
output, of course.  Further, skipped tests are "ok" and not
"not ok".
@rjbs

This comment has been minimized.

Show comment
Hide comment
@rjbs

rjbs Jun 24, 2015

Contributor

I have tested this commit on both Darwin and Win32.

Contributor

rjbs commented Jun 24, 2015

I have tested this commit on both Darwin and Win32.

@briandfoy

This comment has been minimized.

Show comment
Hide comment
@briandfoy

briandfoy Jun 24, 2015

Owner

Okay, I'll try this. Looking at it before I didn't think you'd done anything wrong. Wonder why it worked for the other Windows skips but not yours.

Owner

briandfoy commented Jun 24, 2015

Okay, I'll try this. Looking at it before I didn't think you'd done anything wrong. Wonder why it worked for the other Windows skips but not yours.

briandfoy added a commit that referenced this pull request Jun 24, 2015

Merge pull request #13 from rjbs/win32-test-fixes
fix file_mode_h* tests for win32

@briandfoy briandfoy merged commit 5f40aff into briandfoy:master Jun 24, 2015

@rjbs

This comment has been minimized.

Show comment
Hide comment
@rjbs

rjbs Jun 24, 2015

Contributor

The existing tests for Win32 were all for tests that were expected to pass. I added some of those, too, and they're fine. The difference was that I also tested for what happened when file_mode_has would fail. In that case, non-Win32 would emit "not ok" and diagnostics, but Win32 would emit "ok" and skip and no diagnostics. All I did was account for expecting the skip, not the other differences.

If you get another PR from me in the future, it will probably be to add more tests for when Test::File tests fail… and I'll be sure to run those on Win32 before submitting :)

Contributor

rjbs commented Jun 24, 2015

The existing tests for Win32 were all for tests that were expected to pass. I added some of those, too, and they're fine. The difference was that I also tested for what happened when file_mode_has would fail. In that case, non-Win32 would emit "not ok" and diagnostics, but Win32 would emit "ok" and skip and no diagnostics. All I did was account for expecting the skip, not the other differences.

If you get another PR from me in the future, it will probably be to add more tests for when Test::File tests fail… and I'll be sure to run those on Win32 before submitting :)

@briandfoy

This comment has been minimized.

Show comment
Hide comment
@briandfoy

briandfoy Jul 6, 2015

Owner

I think 1.44 fixes this, although there was one fail on Cygwin on other tests that I think are unrelated. Thanks!

Owner

briandfoy commented Jul 6, 2015

I think 1.44 fixes this, although there was one fail on Cygwin on other tests that I think are unrelated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment