Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race with struct access after calling Stop() #93

Merged
merged 1 commit into from Jul 4, 2020

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Apr 23, 2020

We need to obtain a lock before accessing s.active because Stop() might write to it at the same time.

Followup to #92, where I attempted to fix a Writer-related data race, but left code the vulnerable to race conditions around struct property access.

We need to obtain a lock before accessing `s.active` because `Stop()`
might write to it at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants