New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Model Listenable #4

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@passsy
Contributor

passsy commented Dec 4, 2017

Mirror change in fuchsia repo

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 4, 2017

Codecov Report

Merging #4 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage      90%   90.19%   +0.19%     
==========================================
  Files           1        1              
  Lines          40       51      +11     
==========================================
+ Hits           36       46      +10     
- Misses          4        5       +1
Impacted Files Coverage Δ
lib/scoped_model.dart 90.19% <ø> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16e032...bdc48ef. Read the comment docs.

codecov bot commented Dec 4, 2017

Codecov Report

Merging #4 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage      90%   90.19%   +0.19%     
==========================================
  Files           1        1              
  Lines          40       51      +11     
==========================================
+ Hits           36       46      +10     
- Misses          4        5       +1
Impacted Files Coverage Δ
lib/scoped_model.dart 90.19% <ø> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16e032...bdc48ef. Read the comment docs.

@brianegan

This comment has been minimized.

Show comment
Hide comment
@brianegan

brianegan Jan 4, 2018

Owner

Dang it, not sure how I missed these PRs. Really sorry about that. Pulling em all in! Thanks for your contribution!!!

Owner

brianegan commented Jan 4, 2018

Dang it, not sure how I missed these PRs. Really sorry about that. Pulling em all in! Thanks for your contribution!!!

@brianegan brianegan merged commit bb161e5 into brianegan:master Jan 4, 2018

3 checks passed

codecov/patch Coverage not affected when comparing b16e032...bdc48ef
Details
codecov/project 90.19% (+0.19%) compared to b16e032
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passsy passsy deleted the passsy:implement_listenable branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment