Permalink
Switch branches/tags
Nothing to show
Commits on May 27, 2009
  1. Revert "[ remove closing ?> tag from all files ]"

    This reverts commit a2bdc5c.
    
    I'm going to stop playing in bce's fork, and start messing in my own. Sorry for the mess Brian :)
    Luke Shepard committed May 27, 2009
  2. Revert "[ correct errors in removing trailing ?> ]"

    This reverts commit f963a70.
    Luke Shepard committed May 27, 2009
  3. [ correct errors in removing trailing ?> ]

    In the last commit, I over-aggressively removed closing PHP tags.
    While I dislike the practice of using close tags within templates,
    it is how this library works, so let's put them back.
    
    Checked that all PHP compiles with "php -l".
    Luke Shepard committed May 27, 2009
  4. [ remove closing ?> tag from all files ]

    Reviewed By: Will Norris
    
    Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It
    can unintentionally introduce newlines which causes ridiculous bugs.
    
    This is recommended in the Zend style guide:
    http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
    Luke Shepard committed May 27, 2009
  5. [ Upgrading php-openid test framework to use PHPUnit 3.3 ]

    Reviewed By: Will Norris
    
    The set of tests assumes PHPUnit 2.3, which conflicts with my environment setup.
    I think PHPUnit 3.3 is pretty widespread now, and under active maintenance
    (latest rev 4/10/2009).
    
    There's a few changes included here. I did a few mostly automated code
    transformations:
    
      replace "PHPUnit_TestCase" "PHPUnit_Framework_TestCase"
      replace "PHPUnit_TestSuite" "PHPUnit_Framework_TestSuite"
      removed all require_once "PHPUnit.php" - they are unnecessary.
      "call by reference" is now deprecated, so changed "&$" to "$"
    
    I also made a few changes to admin/testtext.php and Tests/TestDriver.php to
    accomodate the new syntax.
    
    Note that this just upgrades the framework; it does not guarantee that all tests
    pass. I'll submit future diffs to fix or disable failing unit tests. I wasn't
    able to get the tests running with the previous version, so I don't know if
    these have always been failing.
    
    I doubt that the github has automatically running unit tests, but if so then
    we'll have to make sure that the central repo is running the same version of
    PHPUnit.
    Luke Shepard committed May 27, 2009
Commits on Feb 15, 2009
  1. rewording

    committed Feb 15, 2009
Commits on Feb 14, 2009
  1. Merge branch 'master' of git@github.com:bce/php-openid

    Grant Monroe committed Feb 14, 2009
  2. typo

    committed Feb 14, 2009
  3. typo

    committed Feb 14, 2009
  4. added README.git

    committed Feb 14, 2009
Commits on Dec 12, 2008
Commits on Dec 8, 2008
Commits on Nov 14, 2008
  1. [project @ OpenID Signed Assertions(Implementation of old sxip draft)]

      In our solution, one party, which we call the Attribute Provider (AP), provides
    a signed certificate that the the user possesses some attribute (e.g. is over 18).  This certificate is stored as an attribute at the user's OP, and other RPs can request this certificate when they want to verify attributes of the user.
    For the implementation, we have followed the OpenID Signed Assertions
    draft: http://www.mail-archive.com/specs@openid.net/msg00907.html
    
    The Signed Assertions Draft did not specify how signed assertions are
    stored at the OP, so we adopted the following scheme:
     Attribute:    http://X
     Certificate:  http://X/signature
    This enables RPs that don't care about certificates to completely ignore them.  Assertions are SAML documents as specified in the OpenID Signed
    Assertions old draft.
    We are developing a demo application in which a university issues certificates verifying students' age, student-hood, and even their photo (also potentially useful to dating sites).  So basically the university acts as an attribute provider, signing assertions about user claims. These claims are stored as an attribute in the OpenId provider and we can use the OpenID AX protocol to pass assertions as attributes.  The data flow is:
       User requests assertion --- University(Attribute provider)
                               --- (store request)
                               --- Openid provider
       Relying Party(Dating site) --- (fetch request) --- OpenID Provider
    The RP gets the assertion, verifies the signature, and takes actions depending on the result.  In some scenarios, the RP may deny the user request if the attribute verification fails (e.g. the dating site may forbid users under 18).  In other scenarios the RP may treat them differently (e.g. the dating site could tag certified photos as "Verified Photo").
    Note that the RP must have some sort of trust relationship with the AP.  We've tried to keep the system as open as possible.  Our protocol and implementation do not specify how this trust relationship is created or managed.  For example, there could be a PKI specifically set up for verifying claims about student-hood, another trust system set up for verifying claims about age, etc.
     
    Santosh Subramanian
    Shishir Randive
    Michael Hart
    Rob Johnson
    subrasan committed Nov 14, 2008
Commits on Nov 7, 2008
  1. [project @ Message: indentation]

    tailor committed Nov 7, 2008
  2. [project @ getAliasedArg() returns OpenID namespace when $aliased_key…

    … is 'ns']
    
    This fixes an rather cryptic error when using stateless mode via the DumbStore.  The 'ns'
    key can not be found in the alias/namespace mapping (its stored as the "Null Namespace"),
    it must be returned explicitly. The inability to find the key in the mapping results in a
    "Server Denied check_authentication" error, but the error is caused before any callback
    to the server is made.
    
    This also brings the PHP lib more in line with the ruby and python libs.
    tailor committed Nov 7, 2008
Commits on Oct 31, 2008
Commits on Sep 9, 2008
  1. [project @ Update version to 2.1.2]

    Kevin Turner committed Sep 9, 2008
Commits on Jul 11, 2008
  1. [project @ If we're generating user_setup_urls, let's at least do it …

    …correctly]
    tailor committed Jul 11, 2008
Commits on Jul 10, 2008
  1. [project @ Provide the user_setup_url in the Auth_OpenID_SetupNeededR…

    …esponse even in OpenID 2]
    tailor committed Jul 10, 2008
Commits on Jul 8, 2008
Commits on Jun 27, 2008
  1. [project @ Update version to 2.1.1]

    Kevin Turner committed Jun 27, 2008
Commits on Jun 25, 2008
  1. [project @ Make the detect script work with 206 responses from the fe…

    …tcher]
    Kevin Turner committed Jun 25, 2008
  2. [project @ Added a script that helps to update the valid TLD list for…

    … trust root matching]
    Kevin Turner committed Jun 25, 2008
  3. [project @ Updated TLD list in TrustRoot.php]

    Kevin Turner committed Jun 25, 2008
Commits on Jun 23, 2008
  1. [project @ fix accept header]

    willnorris committed Jun 23, 2008
Commits on Jun 22, 2008
  1. [project @ ParanoidHTTPFetcher-strpos-instead-of-preg_match-and-code-…

    …improvements]
    
    ParanoidHTTPFetcher:
     - Fix corner case in get() and post() for headers without any value
        (e.g. 'Expires:')
     - Use strpos() instead of preg_match() when looking for ":" (and
       look for ": " now instead)
    dAniel hAhler committed Jun 22, 2008
Commits on Jun 20, 2008
  1. [project @ Do not attempt HMAC-SHA256 tests if HMAC-SHA256 is not sup…

    …ported]
    http://j3h.us/ committed Jun 20, 2008
  2. [project @ Fix Consumer's OpenID 1 checkid_immediate failure handling…

    … (thanks to Evan Prodromou)]
    http://j3h.us/ committed Jun 20, 2008
  3. [project @ Test and fix HMAC-SHA256]

    http://j3h.us/ committed Jun 20, 2008
Commits on Jun 13, 2008
  1. [project @ etxrd.getCanonicalID: case-insensitive comparsions, patch …

    …from =wil]
    
    1. There should only be a single CanonicalID in each XRD (in the latest XRI
    resolution spec), so I made it use the first CID found instead of the last.
    
    2. Use case-insensitive comparison when comparing CanonicalIDs.
    Kevin Turner committed Jun 13, 2008
Commits on Jun 11, 2008
  1. [project @ Accept response code 206 from fetcher results (part 2). Fi…

    …xes #260]
    Kevin Turner committed Jun 11, 2008
  2. [project @ Add test cases for trust roots with non-ASCII characters i…

    …n path or hostname]
    tailor committed Jun 11, 2008