Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed JDBC string splitting delimiter #1233

Merged
merged 5 commits into from Sep 8, 2019
Merged

Conversation

seybi87
Copy link
Contributor

@seybi87 seybi87 commented Sep 13, 2018

As discussed issue #1184 , currently the JDBC connections Strings are split by ,

This hinders the usage of the JDBC auto-failover features as connection String in the form jdbc:postgresql://host1:port1,host2:port2/database are not possible.

By simply changing the splitting delimiter to ; auto-failover Strings can be used as well as the existing multiple shards connections jdbc:postgresql://host1:port1/database;jdbc:postgresql://host2:port2/database

Updated the readme accordingly

Tested with PostgresSQL driver 42.2.5 and CockroachDB 2.0.1

jdbc/README.md Outdated Show resolved Hide resolved
busbey
busbey approved these changes Sep 8, 2019
@busbey busbey merged commit 77080a3 into brianfrankcooper:master Sep 8, 2019
1 check passed
@busbey busbey mentioned this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants