Convert images back to base64 before reinserting them.

brianloveswords · Dec 3, 2013 · b7a5d78 · b7a5d78
1 parent d992348
commit b7a5d78
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/models/badge-image.js b/models/badge-image.js
@@ -46,7 +46,8 @@ BadgeImage.prototype.bakeAndSave = function (globalCallback) {
   }.bind(this)
 
   const saveImage = function saveImage(bakedImageData, callback) {
-    this.set('image_data', bakedImageData)
+    const b64image = Buffer(bakedImageData).toString('base64')
+    this.set('image_data', b64image)
     this.set('baked', true)
     this.save(callback)
   }.bind(this)

diff --git a/test/badge-image-model.test.js b/test/badge-image-model.test.js
@@ -45,6 +45,14 @@ $.prepareDatabase({
     badgeimage.bakeAndSave(function (err, image) {
       t.notOk(err, 'no error')
 
+      const isRawPng =
+        image
+          .get('image_data')
+          .toString('utf8')
+          .slice(1, 4) == 'PNG'
+
+      t.notOk(isRawPng, 'should not be a raw PNG')
+
       const bakedData = image.toBuffer()
       t.ok(image.get('baked'), 'image says its baked')
       t.notOk(bakedData == unbakedData, 'not the same')