New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Better accessibility: checkboxes, buttons & links, visible/invisible content toggles #128

Merged
merged 23 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@joachimesque
Copy link
Contributor

joachimesque commented Feb 3, 2019

Closes #95.
Closes #96.
Closes #97.
Closes #98.
Closes #69.

@now

This comment has been minimized.

Copy link

now bot commented Feb 3, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@now now bot temporarily deployed to staging Feb 6, 2019 Inactive

@joachimesque joachimesque changed the title [A11y] Slightly more accessible checkboxes [A11y] Better accessibility: checkboxes, buttons & links, visible/invisible content toggles Feb 6, 2019

@now now bot temporarily deployed to staging Feb 6, 2019 Inactive

@joachimesque joachimesque referenced this pull request Feb 6, 2019

Closed

Fix DOM nesting warning #69

@now now bot temporarily deployed to staging Feb 6, 2019 Inactive

@now now bot temporarily deployed to staging Feb 6, 2019 Inactive

@now now bot temporarily deployed to staging Feb 8, 2019 Inactive

@now now bot temporarily deployed to staging Feb 8, 2019 Inactive

@now now bot temporarily deployed to staging Feb 8, 2019 Inactive

@brianlovin

This comment has been minimized.

Copy link
Owner

brianlovin commented Feb 8, 2019

@joachimesque this is unbelievable, can't believe how thorough this is! Really wonderful attention to detail, and this is just overall so much nicer to use the site now. 💜💜💜💜💜

@brianlovin

This comment has been minimized.

Copy link
Owner

brianlovin commented Feb 8, 2019

Is this ready to ship @joachimesque ?

@joachimesque

This comment has been minimized.

Copy link
Contributor Author

joachimesque commented Feb 8, 2019

Thanks ! Yes it's ready to ship, today I learned the existence of useRef, that should explain the late fix to reverse my initial change from a functional component to a Class :)

@brianlovin

This comment has been minimized.

Copy link
Owner

brianlovin commented Feb 8, 2019

Amazing work - let's get this live!

@brianlovin brianlovin merged commit 406d33d into brianlovin:master Feb 8, 2019

1 check passed

now Deployment has completed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment