Revisit PR #840 #919
Merged
Revisit PR #840 #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This might not be needed after all, as it turns out #916 was a bug in MariaDB Connector/C 3.0. |
…MySQL 8.0.1 (brianmario#840)" This reverts commit 5889d04.
MySQL 8.0 replaces my_bool with C99 bool. Earlier versions of MySQL had a typedef to char. Gem users reported failures on big endian systems when using C99 bool types with older MySQLs due to mismatched behavior.
sodabrew
force-pushed
the
typedef_my_bool
branch
from
648dbca to
a799b0b
Compare
Collaborator
Author
|
I like that this removes a warning on older versions of MySQL. Merging. |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #916