Changed toIso8601String helper function #1063
Closed
afrojuju1 wants to merge 1 commit into
Closed
Conversation
This adds extra flexibility around ISO8601 string format
Collaborator
|
If you need custom format, why don't you use |
Collaborator
|
Each |
Owner
|
We would implement this as a separate method anyway, no boolean param. But regardless, doesn't need to go into Carbon. Sounds like a good place for your own class. |
kylekatarnls
added a commit
to kylekatarnls/Carbon
that referenced
this pull request
Apr 13, 2018
Collaborator
|
Will appear in the documentation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
toIso8601Stringto take in a boolean which when false would remove the timezone from ISO8601 string.This adds extra flexibility around ISO8601 string format.