Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDefine User timezone #927
Conversation
thiagocordeiro
added some commits
Mar 31, 2017
This comment has been minimized.
This comment has been minimized.
|
This is really bad solution. You can see that in failing test. On other hand, people do not expect for |
Glavic
closed this
Feb 16, 2018
kylekatarnls
added
the
macro candidate
label
Feb 17, 2018
added a commit
to kylekatarnls/Carbon
that referenced
this pull request
Apr 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks, your code will be added as macro example: |
kylekatarnls
added
documentation
and removed
macro candidate
labels
Apr 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
thiagocordeiro commentedMar 31, 2017
this feature allow developers to define user timezone, when this is set, Carbon will apply given tz to the date before parsing into strings