New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define User timezone #927

Closed
wants to merge 2 commits into
base: master
from

Conversation

3 participants
@thiagocordeiro

thiagocordeiro commented Mar 31, 2017

this feature allow developers to define user timezone, when this is set, Carbon will apply given tz to the date before parsing into strings

thiagocordeiro added some commits Mar 31, 2017

Define User timezone
this feature allow developers to define user timezone, when this is set, Carbon will apply given tz to the date before parsing into strings
@Glavic

This comment has been minimized.

Collaborator

Glavic commented Feb 16, 2018

This is really bad solution. You can see that in failing test. On other hand, people do not expect for format() method to change object timezone. Timezone should be changed on cloned object, not on calling one. Based on that, I don't see this being implemented, since it is too user specific. If you have any new feature, please don't hesitate to comment.

@Glavic Glavic closed this Feb 16, 2018

kylekatarnls added a commit to kylekatarnls/Carbon that referenced this pull request Apr 14, 2018

@kylekatarnls

This comment has been minimized.

Collaborator

kylekatarnls commented Apr 14, 2018

Thanks, your code will be added as macro example:
gh-pages...kylekatarnls:gh-pages-1.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment