Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated consul_snapshot.json.j2 to handle TLS correctly and fix line … #301

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@jasonneurohr
Copy link
Contributor

commented Jul 25, 2019

…formatting

The current template sets the http_addr to 127.0.0.1:8501 when consul_tls_enable is true. This causes the error below:

Snapshot agent error: Unexpected response code: 400 (Client sent an HTTP request to an HTTPS server.#12)

To correct this I've added another if check for consul_tls_enable which will append https:// to the front of the consul_client_address value. I also adjusted the whitespace control to format the file.

Before the change the "ca_file": line is appended to the end of the "http_addr" line, as is "log": to the "key_file": line.

@brianshumate

This comment has been minimized.

Copy link
Owner

commented Jul 26, 2019

Thanks!

@brianshumate brianshumate merged commit b89e82c into brianshumate:master Jul 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@issmirnov

This comment has been minimized.

Copy link
Contributor

commented on c7f4571 Jul 27, 2019

@jasonneurohr can you update the documentation? Our consul playbook doesn't have vault_tls_prefer_server_cipher_suites defined and this commit broke the build.

Did you perhaps mean to use consul_tls_prefer_server_cipher_suites ? (note the consul prefix)

This comment has been minimized.

Copy link
Contributor Author

replied Jul 27, 2019

Hi @issmirnov - good pickup. I'm submitting a fixed version now which also includes the documentation updates.

This comment has been minimized.

Copy link
Contributor Author

replied Jul 27, 2019

Pull request submitted - #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.