Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version check for the log_rotate_max_files key added in consul … #314

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@jasonneurohr
Copy link
Contributor

commented Sep 13, 2019

…1.5.3

If the consul version is below 1.5.3 it fails to start because this key is not implemented.

On a host using Consul 1.5.1
[root@consul01 jneurohr]# /usr/local/bin/consul validate /etc/consul/config.json Config validation failed: Error parsing /etc/consul/config.json: 1 error occurred: * invalid config key log_rotate_max_files

https://github.com/hashicorp/consul/blob/master/CHANGELOG.md#153-july-25-2019
https://www.consul.io/docs/agent/options.html#_log_rotate_max_files

@brianshumate

This comment has been minimized.

Copy link
Owner

commented Sep 13, 2019

:doh: good catch, thanks!

@brianshumate brianshumate merged commit 1db9304 into brianshumate:master Sep 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.