Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SHA224 #438

Closed
Wilfred opened this issue Jan 31, 2017 · 4 comments
Closed

Add support for SHA224 #438

Wilfred opened this issue Jan 31, 2017 · 4 comments

Comments

@Wilfred
Copy link

Wilfred commented Jan 31, 2017

Would it be possible to add support for SHA224? This would allow us to depend entirely on ring in the Remacs project.

@moosingin3space
Copy link

moosingin3space commented Jan 31, 2017

Seconding this, I'd like to be able to completely get rid of Emacs' private implementation of hash functions and replace it with a better-quality crypto library like ring.

@briansmith
Copy link
Owner

Hi, I am happy to help you use ring. I'm a bit unsure what to do, because we intentionally don't support SHA-224 because nobody should be using SHA-224. We only support SHA-1 because of some the-internet-would-break-if-we-didn't things use it like Git and OCSP and TLS.

So, first, can you simply not implement SHA-224 in Remacs? Like, just pretend it doesn't exist? That seems ideal to me, not just as a ring contributor, but also as a crypto person in general.

@moosingin3space
Copy link

@Wilfred do you know what relies on SHA224?

@briansmith
Copy link
Owner

It seems like there's not a strong use case for adding this to ring. In the case of Remacs, you can simply use a pure Emacs Lisp implementation of SHA-224 because nothing performance- or security- critical should need to use it. That would already be required for MD5 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants