Missing Highlights

[briansuda]

There is an issue with the same search term listed consecutively, every other terms is highlighted.

This is an issue with the Regular Expressions NEEDING atleast some sort of whitespace or non-letter
character on both sides of the term. When two terms are consecutive the first term "eats" the white-
space before and after the term, therefore the second term does NOT have a white-space char
before it any longer.

The simple fix is to not require the REGEX to need that white-space buffer, but then it will find word
matches inside of words. So a further testing is needed to fix this issue.

[briansuda]

An alternative (and simpler) regex/replacement could be:

preg_replace(
    '/(?<=^|\W)('.preg_quote($q,'/').')(?=\W|$)/iu',
    "<span class=\"hl$colour\">\$1</span>",
    $tag_matches[3][$i]
)

Note that this only matches standalone words ("q=nana" doesn't highlight "banana"), works on consecutive matches, works at the start and end of strings, and doesn't require adding spaces anywhere.

Also note this still breaks if the search term starts/ends with non-word characters. For example, if the search term is ".", the string "..." would be mangled (the first dot would not be highlighted, but the second two would.)