Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtlcss in the mix #291

Merged
merged 1 commit into from Aug 7, 2022
Merged

Conversation

dgrammatiko
Copy link

Requires an entry point in the templates ending with -rtl.scss, eg template-rtl.scss

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Requires an entry point in the templates ending with `-rtl.scss`, eg `template-rtl.scss`
@brianteeman
Copy link
Owner

why does it need the -rtl.scss enytry point?

the whole point of rtlcss is that it works from the template.CSS

@dgrammatiko
Copy link
Author

dgrammatiko commented Aug 7, 2022

why does it need the -rtl.scss enytry point?

It's basically how the build tools work, they need an entry point to create the .css and .min.css. Adding the entry point (it's just a copy of the same template.scss, so it hardly will ever be touched) means that the tools will work for any template, not just atum or cassiopeia. The other way is to hardcode the template.scss to run twice and produce the -rtl files but that will work only for the hardcoded files. The tools are working on the folder/filename conventions, they can not apply arbitrary logic with out some input...

Actually the template-rtl.scss needs only one line

// Just import the template.scss
@import "template";

@brianteeman
Copy link
Owner

one of us is missing something - in my non-technical terms the workflow would be

  1. generate template.css into the media folder
  2. run rtlcss on media/template.css to create media/template-rtl.css
  3. minify both files

@brianteeman
Copy link
Owner

update - just saw the import one line idea.
I guess that will work as well

will test in the morning

@brianteeman brianteeman merged commit 22d7c29 into brianteeman:bootstrap_rtl Aug 7, 2022
@brianteeman
Copy link
Owner

Unfortunatley that doesnt work

IT seems to get as far as creating the css folders and then dies

image

@dgrammatiko
Copy link
Author

dgrammatiko commented Aug 8, 2022

@brianteeman check #292

I used the code from v5 which has quite some changes in the first PR

@dgrammatiko dgrammatiko deleted the patch-2 branch August 8, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants