From 1feee2f3fce452cf79089fe487d8e6bd45a8b7e2 Mon Sep 17 00:00:00 2001
From: dennemark <martin@formfollowsyou.com>
Date: Tue, 26 Oct 2021 11:18:01 +0200
Subject: [PATCH] fix: :bug: fixed hack to use __rb_createdInstance on
 createPortal in render.ts and in storybook. portal is now outside of
 transformnode -> box is moved from outside into node

---
 src/render.ts                                       | 2 +-
 storybook/stories/babylonjs/Basic/portal.stories.js | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/render.ts b/src/render.ts
index 0ebbbc50..0f188b97 100644
--- a/src/render.ts
+++ b/src/render.ts
@@ -30,7 +30,7 @@ export function createPortal(children: React.ReactNode, containerInfo: any, key?
     target = containerInfo.__rb_createdInstance;
   }
 
-  return reconciler.createPortal(children, containerInfo, null, key);
+  return reconciler.createPortal(children, target, null, key);
 }
 
 /*
diff --git a/storybook/stories/babylonjs/Basic/portal.stories.js b/storybook/stories/babylonjs/Basic/portal.stories.js
index 17f351d8..63d4cde3 100644
--- a/storybook/stories/babylonjs/Basic/portal.stories.js
+++ b/storybook/stories/babylonjs/Basic/portal.stories.js
@@ -27,12 +27,12 @@ function WithCreatePortal() {
 
   return (
     <>
-      <transformNode name="transform-node" ref={transformNodeRef}>
-        {(transformNodeRef.current) &&
+      {(transformNodeRef.current) &&
           createPortal(<box position={new Vector3(0, 1, 0)}>
             <standardMaterial diffuseColor={Color3.Blue() } specularColor={Color3.Black()} />
-          </box>, transformNodeRef.current['__rb_createdInstance'])
+          </box>, transformNodeRef.current)
         }
+      <transformNode name="transform-node" ref={transformNodeRef}>
         <ground name='ground1' width={6} height={6} subdivisions={2} position={new Vector3(0, 0, 0)} />
       </transformNode>
     </>