PHP 8.5: Refactor exponent handling in BigNumber to prevent warning #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-boudry
force-pushed
the
exponent
branch
from
68463a5 to
c1e5419
Compare
Contributor
Author
|
This check is probably not necessary anymore ? |
BenMorel
requested changes
Nov 22, 2025
julien-boudry
force-pushed
the
exponent
branch
from
c1e5419 to
a046947
Compare
julien-boudry
force-pushed
the
exponent
branch
from
a046947 to
90e7070
Compare
Contributor
Author
|
Everything is done with your comments. |
Member
|
Thank you, @julien-boudry! |
Member
|
Released as 0.14.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warning on existing tests from PHP 8.5