Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

fix bug 1343, so View Diff works in IE

  • Loading branch information...
commit 534e739a34e6d71835033bcf560cb54745dd9222 1 parent fec373e
@slanning slanning authored
View
5 comp/widgets/story_prof/story_prof.mc
@@ -101,6 +101,11 @@ if ($id) {
}
+ if (not exists $param->{diff} and exists $param->{'diff.x'}) {
+ # IE only sends diff.x and diff.y for <input type="image">
+ $param->{diff} = 1;
+ }
+
if ($param->{diff}) {
my $version = $story ? $story->get_version : 0;
View
4 lib/Bric/App/Callback/Profile/Story.pm
@@ -330,7 +330,9 @@ sub return : Callback(priority => 6) {
my $story = get_state_data($widget, 'story');
- if ($version_view || $self->value eq 'diff') {
+ # note: $self->value =~ /^\d+$/ is for IE which sends the .x or .y position
+ # of the mouse for <input type="image"> buttons
+ if ($version_view || $self->value eq 'diff' || $self->value =~ /^\d+$/) {
my $story_id = $story->get_id;
$self->clear_my_state if $version_view;
$self->set_redirect("/workflow/profile/story/$story_id/?checkout=1");
View
4 lib/Bric/Changes.pod
@@ -94,6 +94,10 @@ and Safari. [Matt Rolf]
Tweaked Bricolage Instance Name display. [Matt Rolf]
+=item *
+
+Fixed bug 1343, View Diff wasn't working in IE. Reported by Ed Guzman. [Scott]
+
=back
=head1 VERSION 1.10.5 (2008-04-29)
Please sign in to comment.
Something went wrong with that request. Please try again.