Permalink
Commits on Oct 14, 2013
  1. Tweak change log.

    theory committed Oct 14, 2013
  2. Update Chagnes.pod

    phillipadsmith committed with theory Oct 9, 2013
Commits on Sep 2, 2013
  1. Remove use of bare qw() in for blocks.

    theory committed Sep 2, 2013
    Was deprecated in Perl 5.16 and made a syntax error in Perl 5.18. Resolves
Commits on Feb 7, 2012
Commits on Feb 6, 2012
Commits on Dec 7, 2011
  1. Fix drag and drop on IE9.

    theory committed Dec 7, 2011
    This is a direct hack to Prototype. The real fix is in Prototype 1.7, but I
    thought it best not to throw that into the mix for a minor release. So I
    updated it (and script.taculo.us) in master for 2.1.0, but just added a simple
    hack for 2.0.1, borrowing code from [this bug report](https://prototype.lighthouseapp.com/projects/8886/tickets/1229-eventisleftbutton-failure-in-ie9).
    
    [#250 state:resolved]
Commits on Dec 2, 2011
  1. Use imageSubmit for OC and Category delete buttons.

    theory committed Dec 2, 2011
    On Firefox, at least, the image input button created by `/widgets/profile/button.mc` was causing subsequent calls to `form.submit()` to fail. For example, if you deleted a category and then hit the "Note" button, which calls `customSubmit()`, which calls `form.submit()`, the submit would fail. There would be no submit at all. I could not figure out why. Near as I can tell, hitting an image input and then not actually submitting causes the `form.submit()` DOM method to be disabled. But if you hit some other form method, it worked. NFI why.
    
    So work around it by using an image submit link rather than input control. The functionality is the same, but does not break subsequent calls to `form.submit()` by other controls. I'm not altogether happy with this solution, but I can't see any other way around it without digging into the guts of Firefox, which I don't know at all.
    
    Better, down the line, might be to alter the behavior of the Notes, Trail, Bulk Edit, and Diff/View buttons so that they don't do submits, but open a popover window or div. But that's a significan revision for another day (and wouldn't fix existing releases anyway, being new features).
    
    So this will have to do.
    
    [#281 state:closed]
  2. Nick!

    theory committed Dec 2, 2011
  3. Fix Back button when viewing an asset.

    theory committed Dec 2, 2011
    Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In [this commit](534e739) (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.
    
    [#240 state:closed]
Commits on Oct 12, 2011
  1. Fix #279: OC Profile Telmplate Includes list

    Zdravko Balorda committed with theory Oct 11, 2011
Commits on Aug 29, 2011
  1. Credit for fixing #282.

    theory committed Aug 29, 2011
Commits on Aug 17, 2011
  1. Not fix for Bug #277.

    theory committed Aug 17, 2011
  2. More Bug # 277 fixes.

    theory committed Aug 17, 2011
    This time, always die on non-ajax requests. This allows the "publish later" option on the Publish desk to throw an error and return to the same page, rather than load the scheduling page and show the error there.
  3. Yet more fixes for Bug #277.

    theory committed Aug 17, 2011
    Still with `PUBLISH_RELATED_FAIL_BEHAVIOR = fail`, make sure publishes that fail because realteds fail to publish works properly both from desks and from document profiles.
    
    While at it, I filled in some other gaps in the publish logging and rollback logic in the Desk callback.
    
    [#277 state:open]
  4. Make media publish work the same as story publish.

    theory committed Aug 17, 2011
    More work on [#277 state:open].
  5. Move fixes for Bug #277.

    theory committed Aug 17, 2011
    With `PUBLISH_RELATED_FAIL_BEHAVIOR = fail`, things work fine now when publishing via "Check in and Publish" in the story profile and when selecting that option on a desk or workflow, which is an Ajax call.
    
    One side effect is that if the publish fails because the story itself fails to publish (rather than because a related fails), the story is instantly checked out to the user again and put back into workflow. In the interrim, the asset will have been checked in, so the result is a new version number. I think that this is a very minor issue that most folks won't even notice, and is far better than what we had, where things were checked in and sometimes removed from workflow. This is better: other than the new version, it looks like the same page as before, with all the same data, but a nice status message explaining the failure.
    
    In order to properly catch an error when there are no destinations, that exception is now thorwn as an "invalid error" exception rather than a fatal exception. That indicates that it's something to inform the user of, rather than something unexpected (which is a 500). Looking at it, I think it was silly to have been throwing a burn error for that particular error; an invalid error is a much better choice.
    
    Still to do to finish fixing this bug:
    
    * Fix media to follow the same pattern.
    * Make sure that `PUBLISH_RELATED_FAIL_BEHAVIOR = warn` works as expected
    * Make sure that publishing from search results works as expected
    * Make sure that bulk publish works as expected.
    * Make sure all tests continue to pass.
    
    [#277 state:open]
  6. Fix handling of publish failures in Ajax publish requests.

    theory committed Aug 16, 2011
    This fixes the half of bug #277, when one attempts to publish from a desk or workspace.
    
    When `PUBLISH_RELATED_FAIL_BEHAVIOR = fail` and a related asset fails to publish, we now call `raise_conflict` to return a 409 and do a better job displaying *all* the appropriate error messages.
    
    When `PUBLISH_RELATED_FAIL_BEHAVIOR = warn` and  related asset fails to publish, we call a new moethod, `show_accepted()`. This method returns a 202 status code, which I'm abusing a bit here, but it comes closest to what we want. The story properly publishes and disappears from the desk, but a new handler in the Ajax code also shows the errors when related failed to publish. I also added code to abort at the end of the Desk `publish` callback when a request is Ajax so that no other stuff gets sent back to the browser. This is because in "warn" mode, we wnt the full request to succeed, with no rollbacks or anything, and all subsequent code should execute, so that the story will properly be published and removed from workflow.
    
    Tomorrow I'll have to figure out what to do about non-ajax publish requests in order to properly and finally fix bug # 277.
Commits on Aug 6, 2011
  1. Count only active assets.

    theory committed Aug 5, 2011
  2. Add `assets_count()` to Desk and use it for desk counts.

    theory committed Aug 5, 2011
    This is a class method that returns a hash reference mapping desk IDs to counts of assets on those desks. Desks not in the hash refernce should be considered to have 0 assets.
    
    Using it to provide desk counts when the "Show Desk Asset Counts" preference is on. This should be *far* more efficient than the old approach of loading every asset on every desk. [#239 state:resolved]
  3. Add test for new `assets_count()` method.

    theory committed Aug 5, 2011
    Will be used to provide counts of assets on desks in the UI.
  4. Remove asset from workflow on "check in and revert".

    theory committed Aug 5, 2011
    Only when it was just fetched from the library. This was the behavior in 1.10, but was broken sometime since the by a poor selection of variable names. [#253 state:resolved]
  5. Fix deprecated bare `qw()`s.

    theory committed Aug 5, 2011
    Deprecated in Perl 5.14.