…en using "Find Stories"
Or, more specifically, revert it to what it was before. If a story hasn't been published before, then on publish failure the publish status will be false and the publish date and first publishd date will be `undef`. If it *has* been published before, then the publish date will not be udpated. This has been an issue for a long time, so I'll backpatch all the way to 1.10.x.
path (missing the site name). Some ftp clients (eg. FileZilla) call PWD and use this path after changing directories. Conflicts: lib/Bric/Changes.pod
If the "to" choice is the same version as the currently-checked out version, use the currently-checked out representation. This is so we can see changes since the checkout. This is not ideal, frankly, as it's a bit magical. We should consider modifying the functionality for 2.2 so that there is another choice for currently-checked out items, "Current version" or something. When that's selected, the currently-checked out version should be used (for "to" or "from"). Otherwise, use the checked-in version. I think this would be less surprising. Conflicts: lib/Bric/Changes.pod
I've no idea why they were able temporarily disabled to begin with. Seemed an unnecessary defense against something or other. And the downside was discovered with the addition of the `EXPIRE_ON_DEACTIVATE` directive: assets were getting expired every time they were updated via SOAP! The feature is in 2.0, but it seemed prudent to remove the unnecessary deactivation from 1.10, too. So change the code to only activate or deactivate if requested.
This happened for stories in multiple categories -- and probably for stories with multiple pages, too. The problem was that `not_uri => ANY(@files)` was doing `(uri NOT LIKE $file OR uri NOT LIKE $file)`. That `OR` need to be an `AND`. So I fixed the `any_where` function to detect `NOT LIKE` and switch to an `AND` in that case. (Just as an aside, I hate that we're parsing SQL bits here, but at least they're all bits we control in our code). Thanks to Guido Buelskaemper for the report [#156 state:resolved].
…t error when the session does not yet exist.
This commit fixes a few issues, discovered and fixed in reaction to Bug [#121 state:resolved]: * When editing contributors associated with a story or media document, they are no longer paginated. When there were more contributors than would fit on a paginated page, the pagination didn't work and reording didn't work. So by disabling pagination in this case, we get around that issue. Documents with that many contributors are rare, so the trade-off seems worthwhile. * The same turned out to be true for categories when they were displayed and the `ENABLE_CATEGORY_BROWSER` `bricolage.conf` directive was true. So pagination is now diabled there, too. * While at it, the ordering of categories displayed as such was borked, so I fixed it so that they display in URI order, which is what had been expected in the first place. * And finally, when associating contriutors with a media document, the user was prompted to select a role, even if there was only one. We now skip that step, as we had been doing with stories for a while now.
Fix bug where contributor and category search results would be propagated to the contributor and category editing screens with a story or media document. Searches from within documents should cache their own results, separate from the admin search interfaces.
Bric::Util::Burner's `publish()` method no longer removes documents from workflow after publishing them, as such is the responsbility of the code that calls publish. The publish callback already did, and now so does the Bric::SOAP::Workflow `publish()` method. Thanks to David Beaudet for the report and Aaron Fuleki for the steps to replicate [#98 state:resolved].