Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Decimal.parse() uses API unsupported by IE11 #4030

Closed
fabriciomurta opened this issue Jul 27, 2019 · 3 comments

Comments

@fabriciomurta
Copy link
Contributor

commented Jul 27, 2019

The fix in 7f855bf introduced usage of String.startsWith() and String.endsWith(), which is not supported by IE11.

v.lastIndexOf("+", 0) === 0 should be used instead.

The fix for Decimal.Parse pertained issue #3982.

The issue with IE11 was reported thru gitter in this message.

See Also

@fabriciomurta fabriciomurta added this to the 17.9.1 milestone Jul 27, 2019

@fabriciomurta fabriciomurta self-assigned this Jul 27, 2019

fabriciomurta referenced this issue Jul 27, 2019

Fixes issues with Decimal.Parse().
Several parsing scenarios were broken including, but not limited to,
these samples:
- arbitrary character around the number was accepted
- numbers starting with '+' were unparsable
- numbers ending with '+' or '-' were unparsable

Although the latter was not in .NET documentation on Decimal.Parse(), it
worked in practice, so the behavior was ported to Bridge as well as its
expected results.

Related github issue: 3982.

@geoffreymcgill geoffreymcgill changed the title Fix for Decimpal.parse() uses API unsupported by IE11 Fix for Decimal.parse() uses API unsupported by IE11 Jul 27, 2019

@fabriciomurta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

Adding #seealso section to original comment, as a thread was created in Bridge forums regarding this issue.

@hardhub

This comment has been minimized.

Copy link

commented Jul 30, 2019

I got the same trouble.

SCRIPT438: Object doesn't support property or method 'startsWith'

It was used internally in Decimal implementation.

@geoffreymcgill geoffreymcgill modified the milestones: 17.9.1, 17.10.0 Aug 2, 2019

@fabriciomurta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

We have changed it so Bridge no longer references the unsupported methods in IE11; will be in effect next Bridge release (see attached milestone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.