Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.IndexOf and Array.LastIndexOf are static and an instance member #4033

Closed
evantobin opened this issue Jul 30, 2019 · 3 comments

Comments

@evantobin

This comment has been minimized.

Copy link
Author

commented Jul 30, 2019

Frameworks do not use this method as it's not expected to exist: https://github.com/bridgedotnet/Frameworks/search?q=IndexOf&unscoped_q=IndexOf

@fabriciomurta

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Cool, great job in investigating it!
Neither is Bridge.Newtonsoft.Json: https://github.com/bridgedotnet/Bridge.Newtonsoft.Json/search?q=IndexOf&unscoped_q=IndexOf

@fabriciomurta

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

Your contribution has just been merged upstream and will be part of our next Bridge release, pointed by the milestone we attached to this issue and the pull request.

It turned out our Deck project itself used this extraneous implementation. But the fix, as could be expected, was trivially rearranging the bits of the code around the line to turn the call the way it would work in native .NET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.