Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[716] Type.GetTypeCode implementation #3959

Merged
merged 3 commits into from May 22, 2019

Conversation

Projects
None yet
2 participants
@vladsch
Copy link
Member

commented May 16, 2019

@fabriciomurta fabriciomurta changed the title [6180] Type.GetTypeCode implementation [716] Type.GetTypeCode implementation May 17, 2019

vladsch added some commits May 19, 2019

@fabriciomurta fabriciomurta self-requested a review May 21, 2019

@fabriciomurta fabriciomurta self-assigned this May 21, 2019

@fabriciomurta
Copy link
Contributor

left a comment

Changes look good. Added descriptive comments via ad518f1.

@fabriciomurta

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

This pull request also implements #822.

@fabriciomurta
Copy link
Contributor

left a comment

Looks good to go to the next Bridge release!

@fabriciomurta

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

As the references above indicate, issue #977 was also implemented by this pack of changes.

@fabriciomurta fabriciomurta added this to the 17.8.0 milestone May 22, 2019

@fabriciomurta fabriciomurta merged commit 98a5419 into dev May 22, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@fabriciomurta fabriciomurta deleted the ForumHelp6180 branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.