feat: add bundled configuration for Vercel #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
Adds a bundled configuration for Vercel with correct security headers and content type for feeds.xml (if using the RSS plugin).
It also correctly assigns the Bridgetown URL to the VERCEL_URL in non-production environments. This means that if a VERCEL_URL is in the environment, whether production or running via Vercel's CLI locally, the absolute url's will adjust accordingly.
See example of it in use in the deploys on this PR
Context
I spoke about this with Jared. I think pre-1.0 we should make the deployment path to whatever service of your choosing as simple as possible without any need to dig into why something is behaving odd.