Add bundled configuration for GH pages #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah, there's a bona fide bug here around serving a local dev site via the base path. See: #507 (comment) |
Member
|
In light of #510 getting merged in, I have a couple fixes to make here but I can do that after merge. Thanks for working on this! |
Member
|
Fixes and website docs here: 18dbfa9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
This is a 🔦 documentation change.
Summary
Improve the DX when using GH pages.
I've added a bundled configuration that sets up a GH action to deploy the site to GH pages. The configuration also prints out some helpful info to the user about using the
base_pathconfig option as this is likely necessary with Pages.To Do
base_path. As it stands, this PR makes a change that ignores the setting in dev. Discussion is ongoing in Discord (https://discord.com/channels/711236503493148733/711236503975624727/944308666440499270).Context
Resolves #420