New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre commit hook for fasterer #414

Merged
merged 1 commit into from Aug 18, 2016

Conversation

Projects
None yet
3 participants
@morizyun
Contributor

morizyun commented Aug 13, 2016

This hook is to run fasterer to suggest some speed improvements which you can check in detail at the fast-ruby repo.

I am not good at English, but I will always do my best.
If you have any question or advice, please don't hesitate to tell me. 馃嵒

@sds sds merged commit 8928d1d into brigade:master Aug 18, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sds sds added the enhancement label Aug 18, 2016

@morizyun

This comment has been minimized.

Show comment
Hide comment
@morizyun

morizyun Aug 18, 2016

Contributor

@sds Thank you very much 馃憤

Contributor

morizyun commented Aug 18, 2016

@sds Thank you very much 馃憤

Fasterer:
enabled: false
description: 'Suggest some speed improvements'
required_executable: 'fasterer'

This comment has been minimized.

@jawshooah

jawshooah Aug 18, 2016

Collaborator

Seems like this should have include: '**/*.rb' since it's Ruby-specific and doesn't require a full repo context like Brakeman does.

@jawshooah

jawshooah Aug 18, 2016

Collaborator

Seems like this should have include: '**/*.rb' since it's Ruby-specific and doesn't require a full repo context like Brakeman does.

This comment has been minimized.

@sds

sds Aug 18, 2016

Collaborator

Thanks for catching! Addressed in 4d9402b.

@sds

sds Aug 18, 2016

Collaborator

Thanks for catching! Addressed in 4d9402b.

This comment has been minimized.

@morizyun

morizyun Aug 18, 2016

Contributor

Thanks a lot!

@morizyun

morizyun Aug 18, 2016

Contributor

Thanks a lot!

@morizyun morizyun deleted the morizyun:feature/add_pre_commit_hook_for_fasterer branch Aug 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment