Use librarian-puppet for module dependencies. #11

Closed
wants to merge 2 commits into
from

Conversation

2 participants
@christianchristensen

No description provided.

@christianchristensen

This comment has been minimized.

Show comment
Hide comment
@christianchristensen

christianchristensen Sep 3, 2012

Addresses issue #6

Note: I grepped and "guessed" what I needed to change in debian package to depend on puppet (and librarian-puppet) from rubygems instead of apt-get.

For testing I edited the post commit hook, the sudoers, and used this cloudinit

#cloud-config
apt_sources:
 - source: "ppa:brightbox/puppet"
packages:
 - puppet-git-receiver
 - rubygems
runcmd:
- cp -ar /home/ubuntu/.ssh /var/lib/puppet-git-receiver/
- chown -R puppet-git.puppet-git /var/lib/puppet-git-receiver/.ssh
- gem install librarian-puppet --no-ri --no-rdoc

Addresses issue #6

Note: I grepped and "guessed" what I needed to change in debian package to depend on puppet (and librarian-puppet) from rubygems instead of apt-get.

For testing I edited the post commit hook, the sudoers, and used this cloudinit

#cloud-config
apt_sources:
 - source: "ppa:brightbox/puppet"
packages:
 - puppet-git-receiver
 - rubygems
runcmd:
- cp -ar /home/ubuntu/.ssh /var/lib/puppet-git-receiver/
- chown -R puppet-git.puppet-git /var/lib/puppet-git-receiver/.ssh
- gem install librarian-puppet --no-ri --no-rdoc
@christianchristensen

This comment has been minimized.

Show comment
Hide comment
@christianchristensen

christianchristensen Sep 3, 2012

This greatly simplifies the git repo representing your server:

tree
.
├── manifests
│   └── site.pp
├── Puppetfile
└── README.md

1 directory, 4 files

This greatly simplifies the git repo representing your server:

tree
.
├── manifests
│   └── site.pp
├── Puppetfile
└── README.md

1 directory, 4 files
@johnl

This comment has been minimized.

Show comment
Hide comment
@johnl

johnl Mar 24, 2013

Contributor

erk, sorry for the delay responding to this.

I'm not happy changing the debian package to use rubygems for puppet though (or even use rubygems at all during installation). Instead, could you change it to just check if the librarian-puppet executable is available in the path?

That way, the user can just get it installed however they wish, but otherwise it's unobtrusive.

Contributor

johnl commented Mar 24, 2013

erk, sorry for the delay responding to this.

I'm not happy changing the debian package to use rubygems for puppet though (or even use rubygems at all during installation). Instead, could you change it to just check if the librarian-puppet executable is available in the path?

That way, the user can just get it installed however they wish, but otherwise it's unobtrusive.

@johnl

This comment has been minimized.

Show comment
Hide comment
@johnl

johnl Aug 24, 2013

Contributor

@DexterTheDragon implemented this without the dependency on rubygems - merged that pull request (#13)

Contributor

johnl commented Aug 24, 2013

@DexterTheDragon implemented this without the dependency on rubygems - merged that pull request (#13)

@johnl johnl closed this Aug 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment