Skip to content

brightredchilli

  • Joined on Apr 25, 2011

Organizations

@IntrepidPursuits
May 22, 2016
@brightredchilli
May 19, 2016
@brightredchilli

aha....very sneaky here but not a good idea. anyone can override and change the description of an array, including future releases of operating sys…

May 19, 2016
@brightredchilli

same comment here

May 19, 2016
@brightredchilli

use self.trackAnalysis[0.identifier] = $0

May 19, 2016
@brightredchilli

let's append a map in this variable name - this will help us keep tracks, Analysis, and [TrackAnalysis] all straight. So name is trackAnalysisMap

May 19, 2016
@brightredchilli

🚢

May 19, 2016
@brightredchilli

btw, we have some nice methods for table view in Intrepid Swift Wisdom

May 19, 2016
@brightredchilli

hm, use genre instead of self.genre here, since you unwrapped.

May 17, 2016
@brightredchilli

🚢

May 17, 2016
@brightredchilli

seeing that this line is repeated over and over again, you should find a way to consolidate. Consider making an NSNotificationCenter or NSNotificat…

May 17, 2016
@brightredchilli

cleaner here like so ` userInfo = [AnalysisNotificationErrorUserInfoKey : NSError(spotifyError: error) ]

May 17, 2016
@brightredchilli

hmmm....I see why now. I think it might be helpful to make the error parameter generic as well, but that's outside of scope for this pr, we can lea…

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

i think i missed this the last time, but you should also override deinit and call this method if you're targeting iOS8.0. On iOS9, upon dealloc, al…

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

joyful...nice

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

will fetchRecommendedTracks ever return anything other than spotify error? if it doesn't then you can make the callback block return SpotifyError a…

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

So, the repetition of Qu.Main in several different places in the function is probably a good indication that something can be improved here. What y…

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

userInfo is never instantiated here.

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

I think you don't need the as [String] part, would you give that a shot?

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

a little weird, but reduce(0, combine:+) also works

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

valences would be better here

May 17, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#10
@brightredchilli

static let keyTitles = ["C", ...

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

🚢

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

can you check the build phases to see if the two 'embed pods frameworks' are the same? if they are, these lines should definitely not be checked in

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

AnalysisManager is perhaps doing too many things here. SpotifyManager should be the entity responsible for communicating with the Spotify API, so a…

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

yup, remove it, title the commit appropriately.

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

remove print statement

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

This should go in an SPTPartialTrack category extension

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

did you try to use a set? does this conclusively not work? I'm actually not a fan of this. If set does not work, maybe dictionary is a better choic…

May 13, 2016
brightredchilli commented on pull request TOMalley104/spotifyMini#9
@brightredchilli

Both are ok, but since you've been using 'completion' more frequently, it's better to stick with that

Something went wrong with that request. Please try again.