Skip to content

Conversation

@jdmedlin1
Copy link
Contributor

📝 Description

Linting fails in the repository now that we’ve introduced a typescript application. We need to resolve this by either modifying the current linting config to support typescript applications, or if that doesn’t work, we should design each app to manage its own linting.

Issue: Url to Jira Issue

📋 List of Changes

  • Fixed broken paths
  • Reformatted linting issues

🧪 Steps to Test

  1. Execute npm run lint at the root of the project

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken linting configurations in a monorepo by updating ESLint config paths and creating a TypeScript-specific linting setup. The changes address linting failures introduced when TypeScript applications were added to the repository.

Key changes:

  • Updated ESLint config paths to reference the correct configuration files
  • Added a new TypeScript-specific .eslintrc configuration for the HTML5 app template
  • Applied linting fixes to existing JavaScript code to conform to style standards

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/html5-app-template/package.json Updated lint command to use local .eslintrc instead of parent directory config
templates/html5-app-template/.eslintrc Added new TypeScript-specific ESLint configuration with appropriate parser and rules
templates/cra-template-brightsign-dashboard/package.json Fixed ESLint config path to reference grandparent directory
templates/cra-template-brightsign-app/template/src/server/index.js Applied linting fixes for quote consistency and arrow function formatting
templates/cra-template-brightsign-app/package.json Fixed ESLint config path to reference grandparent directory
examples/node-simple-server-example/src/index.js Applied linting fixes for file extension and template literal usage
examples/node-simple-server-example/src/app.test.js Converted callback-based tests to async/await and removed unused import
examples/node-simple-server-example/src/app.js Applied comprehensive linting fixes for quotes, formatting, and code structure
examples/node-simple-server-example/package.json Fixed ESLint config path and corrected source directory reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@blshukla blshukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdmedlin1 jdmedlin1 merged commit e76a5e6 into main Sep 15, 2025
2 checks passed
@jdmedlin1 jdmedlin1 deleted the PE-1008 branch September 15, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants