Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: master
Commits on Jun 14, 2012
  1. @fabpot

    fixed CS

    fabpot authored
  2. @fabpot
  3. @fabpot

    merged branch fabpot/middleware (PR #362)

    fabpot authored
    Commits
    -------
    
    d53119e added a route after middleware
    794b3c2 renamed middleware() to before()
    
    Discussion
    ----------
    
    Implements route after middleware (closes #336)
    
    This PR renames the `middleware` method to `before` and adds a new `after` route middleware.
    
    These changes make Silex more consistent from a user point of view:
    
     * he can do something before the route callback on an application, a route collection, or just a route (by calling the `before` method on these objects);
    
     * he can do something after the route callback by calling the `after` method on an application, a route collection, or just a route.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-06-13T18:20:37Z
    
    I thought about using the `middleware` method for both before and after by passing the callback as an argument. But this has several drawback:
    
     * we loose the symmetry with the application before/after calls;
     * the developer must remember to manually call the callback (and symfony1 proves that many devs actually forgets about that);
     * this would act as a filter chain where the order of execution is not always clear when you have many filters.
  4. @fabpot

    merged branch stof/composer_constraint (PR #366)

    fabpot authored
    Commits
    -------
    
    1e5d0f4 Fixed the composer constraints to have an upper bound
    
    Discussion
    ----------
    
    Fixed the composer constraints to have an upper bound
  5. @stof
  6. @fabpot

    fixed build command

    fabpot authored
  7. @fabpot

    fixed markup

    fabpot authored
  8. @fabpot

    added a fat archive which contains many more Symfony component and th…

    fabpot authored
    …ird-party libraries (closes #365)
  9. @fabpot

    added a route after middleware

    fabpot authored
  10. @fabpot
  11. @fabpot

    fixed the phar compiler

    fabpot authored
  12. @fabpot
  13. @fabpot
  14. @fabpot

    merged branch alOneh/form-docs (PR #77)

    fabpot authored
    Commits
    -------
    
    256859b [docs] Documentation for FormExtension
    
    Discussion
    ----------
    
    Form docs
    
    [docs] FormExtension docs
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-05-11T17:58:13Z
    
    I think the form doc is now clean, isnt'it ?
    
    ---------------------------------------------------------------------------
    
    by brikou at 2011-06-27T19:19:46Z
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by rkmax at 2011-07-29T19:30:28Z
    
    thanks, i'm looking for this
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-07-29T19:32:29Z
    
    @fabpot can you merge this if you are agree with that pull ?
    
    ---------------------------------------------------------------------------
    
    by rkmax at 2011-07-30T14:27:09Z
    
    can you explain what /vendor/symfony/src need exactly
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-07-31T13:27:39Z
    
    /vendor/symfony/src is use to load the Symfony Form component, the [Symfony Bridge](http://api.symfony.com/2.0/Symfony/Bridge/Twig/Extension.html) who provide extensions for Form and Translation in Twig
    
    ---------------------------------------------------------------------------
    
    by rkmax at 2011-08-01T09:51:30Z
    
    thanks @alOneh
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011-09-18T15:06:44Z
    
    @fabpot is there anything missing? Would be nice to get this merged finally.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-09-20T08:42:49Z
    
    @fabpot are you agree with that PR ?
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-09-22T10:39:23Z
    
    I just updated the form provider documenation
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011-10-07T14:41:17Z
    
    Keep an eye on #182.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-10-07T15:00:28Z
    
    Seems good to me. I will update the doc when it will be merged.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-10-09T12:57:51Z
    
    @fabpot : I updated my proposal PR for the FormServiceProvider. Can you check if there is anything missing ? /cc igorw
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011-10-09T13:05:49Z
    
    Looks good to me.
    
    Might be interesting to add another section about validation using the `validation_constraint` form option, see also http://knplabs.com/en/blog-csi/symfony-validators-standalone
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-10-09T14:02:38Z
    
    I updated the example with the validation_constraint, I think now its good.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-10-10T19:51:56Z
    
    poke @fabpot
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011-10-10T19:55:05Z
    
    Looks good to me.
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011-10-16T23:53:48Z
    
    Hm, maybe validation_constraint should be a separate example. Also we should not use the UrlGenerator.
    
    IMO it needs to be clear that those things are optional.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2011-10-18T09:01:48Z
    
    @igorw, I use the UrlGenerator because I can't get a fully working example without it.
    
    ---------------------------------------------------------------------------
    
    by netzhuffle at 2011-11-28T17:15:12Z
    
    @alOneh You could try $request->getUriForPath() instead of the UrlGenerator.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2012-01-16T14:47:20Z
    
    is this PR is ready for merge after the latest change ?
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-01-16T15:02:12Z
    
    It introduces extensions.rst which was renamed to providers.rst. You need to merge upstream master into your branch and then make sure everything is correct.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2012-01-16T15:52:00Z
    
    My mistake. I fix this.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2012-02-12T23:00:03Z
    
    poke @igorw @fabpot
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-02-12T23:04:01Z
    
    This (still) looks good to me.
    
    Minor thing: API docs links should probably be changed to 2.1 now. Not sure if others are also affected.
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2012-02-12T23:08:06Z
    
    Others are not yet affected. Maybe in a single PR for all API docs links
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2012-02-22T11:03:39Z
    
    poke @igorw , @fabpot
    
    ---------------------------------------------------------------------------
    
    by alOneh at 2012-03-02T14:01:17Z
    
    @igorw I updated the docs references to 2.1, ready for merge now ? /cc @fabpot
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-03-02T15:30:52Z
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-06-13T18:59:12Z
    
    Can you squash your commits. I will then merge and made some changes due to some recent updates to Silex. Thanks.
Commits on Jun 13, 2012
  1. @alOneh
  2. @fabpot
  3. @fabpot

    merged branch stof/locale_listener (PR #361)

    fabpot authored
    Commits
    -------
    
    d8b0d79 Added the LocaleListener to handle setting the locale
    
    Discussion
    ----------
    
    Added the LocaleListener to handle setting the locale
    
    This registers the LocaleListener setting the request locale according to the matching of the special ``_locale`` parameter and setting the locale in the routing RequestContext so that it is always available.
    
    This PR should be merged only after the update of the subtree split as it requires the typehint change merged just before in Symfony
  4. @fabpot

    updated vendors

    fabpot authored
  5. @stof
  6. @fabpot

    merged branch stof/twig_provider_length (PR #360)

    fabpot authored
    Commits
    -------
    
    8ccf217 Removed the aliases for classes
    
    Discussion
    ----------
    
    Removed the aliases for classes
    
    They are no longer needed as there is no conflict anymore with the
    silex providers since their renaming. And changing the length of the
    file fixes #359
  7. @fabpot
  8. @stof

    Removed the aliases for classes

    stof authored
    They are no longer needed as there is no conflict anymore with the
    silex providers since their renaming. And changing the length of the
    file fixes # 359
  9. @fabpot

    fixed CS

    fabpot authored
  10. @fabpot

    merged branch stof/phpdoc (PR #358)

    fabpot authored
    Commits
    -------
    
    70da9e1 Removed unused property
    a1a7306 Added a missing property
    5c48a20 Fixed the phpdoc
    
    Discussion
    ----------
    
    Phpdoc
    
    This fixes a bunch of phpdoc to make the autocompletion work in IDEs.
  11. @stof

    Removed unused property

    stof authored
  12. @stof

    Added a missing property

    stof authored
  13. @stof

    Fixed the phpdoc

    stof authored
  14. @fabpot
  15. @fabpot
  16. @fabpot

    fixed doc markup

    fabpot authored
  17. @fabpot

    merged branch adrienbrault/doc-fixes (PR #357)

    fabpot authored
    Commits
    -------
    
    54aa24f [Doc] Fix code-blocks, links, identation
    
    Discussion
    ----------
    
    [Doc] Fix missing code-block tag, links, identation
    
    Hi,
    
    I fixed some presentations problems, and added some links to the symfony api.
    
    ---------------------------------------------------------------------------
    
    by adrienbrault at 2012-06-13T10:04:39Z
    
    Updated my commit regarding your comments.
    
    Still, the 2 php block here http://silex.sensiolabs.org/doc/cookbook/json_request_body.html are not formatted.
    
    ---------------------------------------------------------------------------
    
    by adrienbrault at 2012-06-13T10:22:42Z
    
    Nevermind about "json_request_body", i thought the website was up to date, sorry!
  18. @fabpot

    merged branch fabpot/security (PR #356)

    fabpot authored
    Commits
    -------
    
    1886811 tweaked some docs
    6a0f05d tweaked docs
    4313458 updated vendors
    1286709 moved security to the dev requirements
    320a268 updated the changelog
    2b711bc added support for the Symfony Security component
    
    Discussion
    ----------
    
    added support for the Symfony Security component
    
    Some few things are not (yet) configurable, but this extension should cover most common needs and then some more. It is actually as powerful as the support we have in the Symfony full-stack framework.
    
    ---------------------------------------------------------------------------
    
    by davedevelopment at 2012-06-13T08:30:42Z
    
    This is awesome. Not only can I throw away my sketchy implementation, I can see all the things I did wrong! Cheers @fabpot!
  19. @adrienbrault
  20. @fabpot

    tweaked some docs

    fabpot authored
  21. @fabpot

    tweaked docs

    fabpot authored
Something went wrong with that request. Please try again.