The bug of deciding NTL version in HElib. #4

Closed
NanXiao opened this Issue Mar 21, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@NanXiao
Contributor

NanXiao commented Mar 21, 2017

Now, the HEAT's HElib has a bug in NumbTh.h:

// Test for the "right version" of NTL (currently 9.4.0)
#if ((NTL_MAJOR_VERSION<9)||(NTL_MINOR_VERSION<4)||(NTL_REVISION<0))
#error "This version of HElib requires NTL version 9.4.0 or above"
#endif

If the NTL's version is 10.3.0, Helib will also report error. So I think HEAT should use the newest HElib in which the NumbTh.h has been changed:

// Test for the "right version" of NTL (currently 9.4.0)
#if ((NTL_MAJOR_VERSION<9)||(NTL_MAJOR_VERSION==9 && NTL_MINOR_VERSION<4))
#error "This version of HElib requires NTL version 9.4.0 or above"
#endif
@svivekv

This comment has been minimized.

Show comment
Hide comment
@svivekv

svivekv Mar 21, 2017

Contributor

Note that HElib has been included as a git submodule and hence can be independently updated.

Contributor

svivekv commented Mar 21, 2017

Note that HElib has been included as a git submodule and hence can be independently updated.

@svivekv svivekv closed this Mar 21, 2017

@NanXiao

This comment has been minimized.

Show comment
Hide comment
@NanXiao

NanXiao Mar 22, 2017

Contributor

But if the user use git clone --recursive command to clone HEAT, the HElib with the bug version will be cloned, and this HElib is not of a out-of-box product, and need to be updated to the newest Helib. I think this violates the original intention of HEAT.

Thanks!

Contributor

NanXiao commented Mar 22, 2017

But if the user use git clone --recursive command to clone HEAT, the HElib with the bug version will be cloned, and this HElib is not of a out-of-box product, and need to be updated to the newest Helib. I think this violates the original intention of HEAT.

Thanks!

@svivekv

This comment has been minimized.

Show comment
Hide comment
@svivekv

svivekv Mar 22, 2017

Contributor

Okay. Will fix this.

Contributor

svivekv commented Mar 22, 2017

Okay. Will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment