Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Jersey Shore #454

Merged
merged 2 commits into from Oct 2, 2019
Merged

Added Jersey Shore #454

merged 2 commits into from Oct 2, 2019

Conversation

@Easybuoy
Copy link
Contributor

Easybuoy commented Sep 30, 2019

  • πŸ” I have searched the data.js file and confirmed I am not adding a duplicate entry. Note: Different versions of the same show/movie are okay to add such as Lion King (1994) and Lion King (2019) or Rent (movie) and Rent (musical).
  • πŸ’œ I have checked Issues and Pull Requests to confirm I am not adding a duplicate entry that is pending approval.
  • 🌈 I have added a single year under year. Note: Do not add ranges such as 2017-2019.
  • πŸ“… I have added a type from one of the following: movie , tv or musical.
  • πŸ”— I have added the IMDB page or Playbill archive page under itemLink.
  • 3️⃣ I have at least three emojis listed under emojiImgs.
  • 5️⃣ I have a maximum of five emojis listed under emojiImgs.
  • πŸ‘ My pull request has a descriptive title (such as Added The Lion King or Added Black Panther, The Avengers: Endgame and Thor).
  • ⭐ My genres are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "genres": ["adventure","mystery","animation"] and not this "genres":["adventure, mystery, animation"]).
  • πŸ–οΈ I have placed the new show(s) or movie(s) in alphabetical order based on title. If the show or movie starts with 'the', then use the second word to alphabetize.

Closes #383

@Easybuoy Easybuoy requested a review from brittanyrw as a code owner Sep 30, 2019
@auto-comment

This comment has been minimized.

Copy link

auto-comment bot commented Sep 30, 2019

Thank you for opening this pull request, your code will be reviewed soon!
Important Notes:

There is a limit to the number of pull requests you can make on this project due to the large amount of activity. Please limit yourself to up to 4 additions to this project. (Example: Complete 1 feature and add three movies, complete 4 Issues for movies and add one feature, add four movies, etc). Some Issues ask that you add mulitple shows/movies, that will count as 1 addition. The limit will be removed in the future but for now I want to allow as many people as possible to have the chance contribute.

If any updates need to be made, I will leave a comment for you here outlining exactly what you need to change for your pull request to be accepted. πŸ’–

In the meantime, feel free to contribute to one of my other projects:
πŸ“š EmojiPages - A listing of books and plays. (https://github.com/brittanyrw/emojipages)
🎢 EmojiBops - A listing of songs. (https://github.com/brittanyrw/emojibops)

@brittanyrw

This comment has been minimized.

Copy link
Owner

brittanyrw commented Oct 2, 2019

Thanks for contributing to EmojiScreen! πŸ’œYou should be able to see your addition on emojiscreen.com today! πŸ₯³

And just an informational note: We have paused contributions (new pull requests, issues and comments) on this project for today so we can review the backlog of pull requests.

@brittanyrw brittanyrw merged commit 76b537d into brittanyrw:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.