Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pippin musical #515

Merged
merged 5 commits into from Oct 4, 2019

Conversation

@NitinNair89
Copy link
Contributor

NitinNair89 commented Oct 1, 2019

Added Pippin musical

  • πŸ” I have searched the data.js file and confirmed I am not adding a duplicate entry. Note: Different versions of the same show/movie are okay to add such as Lion King (1994) and Lion King (2019) or Rent (movie) and Rent (musical).
  • πŸ’œ I have checked Issues and Pull Requests to confirm I am not adding a duplicate entry that is pending approval.
  • 🌈 I have added a single year under year. Note: Do not add ranges such as 2017-2019.
  • πŸ“… I have added a type from one of the following: movie , tv or musical.
  • πŸ”— I have added the IMDB page or Playbill archive page under itemLink.
  • 3️⃣ I have at least three emojis listed under emojiImgs.
  • 5️⃣ I have a maximum of five emojis listed under emojiImgs.
  • πŸ‘ My pull request has a descriptive title (such as Added The Lion King or Added Black Panther, The Avengers: Endgame and Thor).
  • ⭐ My genres are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "genres": ["adventure","mystery","animation"] and not this "genres":["adventure, mystery, animation"]).
  • πŸ–οΈ I have placed the new show(s) or movie(s) in alphabetical order based on title. If the show or movie starts with 'the', then use the second word to alphabetize.
Added Pippin musical
@NitinNair89 NitinNair89 requested a review from brittanyrw as a code owner Oct 1, 2019
@auto-comment

This comment has been minimized.

Copy link

auto-comment bot commented Oct 1, 2019

Thank you for opening this pull request, your code will be reviewed soon!
Important Notes:

We are limiting contributions per person to 4 additions across EmojiScreen, EmojiBops and EmojiPages. Please limit yourself to up to 4 additions across the three emoji projects. (Example One: Complete 1 feature, add two movies, and add one song; Example Two: complete 4 Issues for movies; Example Three: add one song, 2 movies and one book, etc). This is due to the high level of activity on these projects at the moment. Some Issues ask you to add multiple movies, those Issues count as 1 addition. We want to make sure many people have a chance to contribute. The limit will be lifted once the activity has died down. πŸ™‚

If any updates need to be made, I will leave a comment for you here outlining exactly what you need to change for your pull request to be accepted. πŸ’–

In the meantime, feel free to contribute to one of my other projects:
πŸ“š EmojiPages - A listing of books and plays. (https://github.com/brittanyrw/emojipages)
🎢 EmojiBops - A listing of songs. (https://github.com/brittanyrw/emojibops)

@NitinNair89

This comment has been minimized.

Copy link
Contributor Author

NitinNair89 commented Oct 1, 2019

Also closes #548

@brittanyrw brittanyrw merged commit 1161dd4 into brittanyrw:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.