Browse files

Don't use 'should' in specs.

  • Loading branch information...
1 parent 797dae1 commit 07d05b5745c95cb1ffb1c5d65bf76aa0a33a6bba @brixen committed Dec 17, 2010
Showing with 2 additions and 2 deletions.
  1. +2 −2 spec/library/table_spec.rb
4 spec/library/table_spec.rb
@@ -1,12 +1,12 @@
require 'spec/spec_helper'
describe "Table" do
- it "should be created by a _list_ table literal with expressions" do
+ it "is created by a sequence of values in paretheses" do
table = Poison::CodeLoader.execute "(1, 2, 3)"
table.should be_kind_of(Table)
- it "should be created by a _hash_ table literal with assignments" do
+ it "is created by sequence of assignments in parentheses" do
table = Poison::CodeLoader.execute "(a = 1, b = 2, c = 3)"
table.should be_kind_of(Table)

2 comments on commit 07d05b5


Sorry but why not?


Because it is entirely unnecessary and creates clutter when reading the descriptions. A thing has a particular behavior. The description string states that in active, concise language. The test will verify whether the description is correct. As such, 'a.should == b' is testing the expectation that "a is equal to b".

Please sign in to comment.