Skip to content
Permalink
Browse files Browse the repository at this point in the history
Fix potential memory leak in Kerberos scripts
Reported by Maksim Shudrak.
  • Loading branch information
jsiwek committed Sep 10, 2018
1 parent 7e26bfe commit 34d0cf8
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
6 changes: 4 additions & 2 deletions scripts/base/protocols/krb/main.bro
Expand Up @@ -140,7 +140,8 @@ event krb_as_request(c: connection, msg: KDC_Request) &priority=5

c$krb$request_type = "AS";
c$krb$client = fmt("%s/%s", msg?$client_name ? msg$client_name : "", msg$service_realm);
c$krb$service = msg$service_name;
if ( msg?$service_name )
c$krb$service = msg$service_name;

if ( msg?$from )
c$krb$from = msg$from;
Expand Down Expand Up @@ -183,7 +184,8 @@ event krb_tgs_request(c: connection, msg: KDC_Request) &priority=5
return;

c$krb$request_type = "TGS";
c$krb$service = msg$service_name;
if ( msg?$service_name )
c$krb$service = msg$service_name;
if ( msg?$from )
c$krb$from = msg$from;
c$krb$till = msg$till;
Expand Down
Binary file added testing/btest/Traces/krb/optional-service-name.pcap
Binary file not shown.
8 changes: 8 additions & 0 deletions testing/btest/core/leaks/krb-service-name.test
@@ -0,0 +1,8 @@
# Needs perftools support.
#
# @TEST-REQUIRES: bro --help 2>&1 | grep -q mem-leaks
#
# @TEST-GROUP: leaks
#
# @TEST-EXEC: HEAP_CHECK_DUMP_DIRECTORY=. HEAPCHECK=local btest-bg-run bro bro -m -r $TRACES/krb/optional-service-name.pcap
# @TEST-EXEC: btest-bg-wait 60

0 comments on commit 34d0cf8

Please sign in to comment.