Skip to content

Conversation

@davidangb
Copy link
Contributor

@davidangb davidangb commented Mar 13, 2017

This wants:
broadinstitute/firecloud-develop#341
broadinstitute/firecloud-develop#342
broadinstitute/firecloud-develop#344

removes kamon from agora.

I rebased, ran unit tests, started the app locally and tried a few endpoints in swagger, and watched the logs.

  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
  • Submitter: JIRA ticket checks:
    • Acceptance criteria exists and is met
    • Note any changes to implementation from the description
    • Add notes on what you've tested
  • Submitter: Update RC_XXX release ticket with any config or environment changes necessary
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them
  • Tell the tech lead (TL) that the PR exists if they wants to look at it
  • Anoint a lead reviewer (LR). Assign PR to LR
  • Review cycle:
    • LR reviews
    • Rest of team may comment on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH
    • Submitter updates documentation as needed
    • Submitter reassigns to LR for further feedback
  • TL sign off
  • LR sign off
  • Product Owner sign off
  • Assign to submitter to finalize
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Squash commits and merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Verify swagger UI on dev environment still works after deployment
  • Submitter: Inform other teams of any API changes via hipchat and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@davidangb davidangb changed the title no kamon GAWB-1273: no kamon Mar 13, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 84.785% when pulling 7db7e3a on da_noKamon into cf2cdc1 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 84.785% when pulling eb54640 on da_noKamon into cf2cdc1 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 84.785% when pulling 15cbfdf on da_noKamon into cf2cdc1 on develop.

@helgridly
Copy link
Contributor

Glorious. Don't forget the FiaB_lite branch in firecloud-develop too! 👍

@helgridly helgridly merged commit 2a3c017 into develop Mar 15, 2017
@helgridly helgridly deleted the da_noKamon branch March 15, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants