Permalink
...
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
broadinstitute/cromwell
BGI-flexlab/cromwell
GiladOlswang/cromwell
Horneth/cromwell
LREN-CHUV/cromwell
SunbyMoon/cromwell
agduncan94/cromwell
antonkulaga/cromwell
bestwpw/cromwell
buchanae/cromwell
bw2/cromwell
cemoulto/cromwell
cowmoo/cromwell
danbills/cromwell
dayedepps/cromwell
delagoya/cromwell
delocalizer/cromwell
dgtester/cromwell
ffinfo/cromwell
gitter-badger/cromwell
indraniel/cromwell
jfiksel/cromwell
jnsunkersett/cromwell
knoblett/cromwell
kshakir/cromwell
ohsu-comp-bio/cromwell
orodeh/cromwell
pjeraldo/cromwell
qqss88/cromwell
seandavi/cromwell-1
shivagopalan/cromwell
sleongmgi/cromwell
tcong2012/cromwell
teamcgc/cromwell
vivovip/cromwell
ww102111/cromwell
xxu46/cromwell
yunzhengluoyi/cromwell
zebbra2014/cromwell
Nothing to show
Choose a base branch
0.19_hotfix
0.21_fc_hotfix
0.21_hotfix
0.22_hotfix
23_hotfix
24_hotfix
25_hotfix
26_hotfix
26_hotfix_2
27_hotfix
28_hotfix
CromwellClientFailures
FixGcrToken
aws_backend
cjl_sneaky_test
cromwell-1990
cromwell-2094_tj_rebase
cromwell-2373
cromwell-2385
deb_add_pull_approve
dev_ccc_test
develop
dockerCacheMode
firecloud
jg_reactive_platform
jg_scala_2_12
jg_status_endpoint
jg_typesafe
jg_use_grpc_codes
ks_allow_backends
ks_allow_dotted_dirs
ks_handle_non_200
ks_local_docker_hash
ks_rm_prememption_debug
ks_uger_array_wip
master
mlc_config_cwl_gull
mlc_confirm_preemptible
mock_failure
mock_failure_2
nb_run_tests
papi_staging
release-0.17
release-0.18
release-0.19
rm_jg_jes_retry
rm_log_failures
rm_testTes
tes_failure
tj_dockerfix_26_hotfix
tj_dockerfix_26_hotfix_2
wdl_facelift
Nothing to show
Choose a Head Repository
broadinstitute/cromwell
BGI-flexlab/cromwell
GiladOlswang/cromwell
Horneth/cromwell
LREN-CHUV/cromwell
SunbyMoon/cromwell
agduncan94/cromwell
antonkulaga/cromwell
bestwpw/cromwell
buchanae/cromwell
bw2/cromwell
cemoulto/cromwell
cowmoo/cromwell
danbills/cromwell
dayedepps/cromwell
delagoya/cromwell
delocalizer/cromwell
dgtester/cromwell
ffinfo/cromwell
gitter-badger/cromwell
indraniel/cromwell
jfiksel/cromwell
jnsunkersett/cromwell
knoblett/cromwell
kshakir/cromwell
ohsu-comp-bio/cromwell
orodeh/cromwell
pjeraldo/cromwell
qqss88/cromwell
seandavi/cromwell-1
shivagopalan/cromwell
sleongmgi/cromwell
tcong2012/cromwell
teamcgc/cromwell
vivovip/cromwell
ww102111/cromwell
xxu46/cromwell
yunzhengluoyi/cromwell
zebbra2014/cromwell
Nothing to show
Choose a head branch
0.19_hotfix
0.21_fc_hotfix
0.21_hotfix
0.22_hotfix
23_hotfix
24_hotfix
25_hotfix
26_hotfix
26_hotfix_2
27_hotfix
28_hotfix
CromwellClientFailures
FixGcrToken
aws_backend
cjl_sneaky_test
cromwell-1990
cromwell-2094_tj_rebase
cromwell-2373
cromwell-2385
deb_add_pull_approve
dev_ccc_test
develop
dockerCacheMode
firecloud
jg_reactive_platform
jg_scala_2_12
jg_status_endpoint
jg_typesafe
jg_use_grpc_codes
ks_allow_backends
ks_allow_dotted_dirs
ks_handle_non_200
ks_local_docker_hash
ks_rm_prememption_debug
ks_uger_array_wip
master
mlc_config_cwl_gull
mlc_confirm_preemptible
mock_failure
mock_failure_2
nb_run_tests
papi_staging
release-0.17
release-0.18
release-0.19
rm_jg_jes_retry
rm_log_failures
rm_testTes
tes_failure
tj_dockerfix_26_hotfix
tj_dockerfix_26_hotfix_2
wdl_facelift
Nothing to show
15
contributors
Commits on Apr 11, 2017
|
|
ruchim + ruchim |
Update cromwell version from 26 to 27
|
fd15a89
|
Commits on Apr 12, 2017
|
|
kshakir + geoffjentry |
Updated to Slick 3.2. (#2104)
Removed deadlock workaround. Minimal updates to fix depracated usage. Old Slick 3.1 style names are still used in scala, ex: `val driver: JdbcProfile`. Added notes about SQL converters handling empty LOBs. |
1906bdf
|
|||
|
|
geoffjentry |
EngineWorkflowFinalizationActor only had a single implementation, rem…
…ove layer of indirection (#2155) |
91dd653
|
Commits on Apr 14, 2017
|
|
cjllanwarne |
Upgrade test script
|
Some checks were not successful2 errored and 1 successful checks |
7947d4c
|
||
|
|
cjllanwarne |
Merge pull request #2164 from broadinstitute/cjl_test_upgrade
Test_upgrade script |
5a1f768
|
|||
|
|
ruchim |
Config-specified Default runtime attributes (#2121)
grab runtime attribute defaults from reference.conf, add deprecation warnings, introduced the BadDefaultAttribute WdlValue. |
9460d47
|
|||
|
|
Horneth |
Enable local docker lookup (#2139)
* Added a docker cli flow. Changed the default behavior to use the cli (aka local) flow, with an option to add or switch to the remote registry flow. * Add enable flag for docker hash lookup * Disable docker lookup if backend doesn't support docker * changelog * get ready for merge |
9aff9f2
|
Commits on Apr 18, 2017
|
|
francares |
Initial implementation of HtCondor backend using configurable backend. (
#2141) Fixed documentation on Native specs. Generalized memory validation in order to support disk validation based on information unit. Prettyfing bash scripts. Updating README. Changes after rebase. |
89d0b9d
|
Commits on Apr 19, 2017
|
|
katevoss |
Removing CLI from the Readme (#2161)
* Removing CLI from the Readme * making it one line in the TOC * updating to the published url |
6d79d0a
|
Commits on Apr 20, 2017
|
|
cjllanwarne |
Cromwell API client (for Centaur)
|
All checks have passed4 successful checks |
6eb104b
|
||
|
|
cjllanwarne |
Merge pull request #2169 from broadinstitute/cjl_cromwell_api_client
Cromwell API client for Centaur. Closes #2128 |
0853385
|
Commits on Apr 21, 2017
|
|
Horneth |
Support for docker hash lookup of public quay.io images (#2184)
* add docker hash lookup for public quay.io images * custom centaur |
2033421
|
|||
|
|
Horneth |
centaur develop
|
229e974
|
|||
|
|
Horneth |
Some Joint Genotyping related improvements (#2180)
* Add 410 as retryable error and rework metadata building a little. * custom centaur * add CRDT test for call executions status * update timing diagram * eventuallify test * PR comments * oops * centaur develop |
d1c8ea0
|
|||
|
|
cjllanwarne |
Publish cromwell-api-client artifact
|
Some checks were not successful2 errored and 1 successful checks |
63d133a
|
||
|
|
cjllanwarne |
Merge pull request #2192 from broadinstitute/cjl_aggregate_client
Publish cromwell-api-client artifact |
3619ba8
|
|||
|
|
cjllanwarne |
Client publish fixup
|
1ad7716
|
|||
|
|
cjllanwarne |
Merge pull request #2194 from broadinstitute/cjl_client_publish-fixup
Client publish fixup |
77b8b1d
|
Commits on Apr 24, 2017
|
|
cjllanwarne |
(Centaur Port) Decode responses
|
Some checks were not successful1 failing and 3 successful checks |
754134b
|
||
|
|
cjllanwarne |
Remove race conditions from WriteMetadataActorSpec
|
All checks have passed4 successful checks |
5b66bf5
|
||
|
|
cjllanwarne |
Merge pull request #2199 from broadinstitute/cjl_decode_responses
(Centaur Port) Decode responses |
9a9745a
|
|||
|
|
cjllanwarne |
Merge pull request #2195 from broadinstitute/cjl_flaky_test_2193
Remove race conditions from WriteMetadataActorSpec. Closes #2193 |
20f8687
|
|||
|
|
cjllanwarne |
Deprecation errors for DB configs
|
All checks have passed4 successful checks |
c81343c
|
Commits on Apr 25, 2017
|
|
cjllanwarne |
Merge pull request #2200 from broadinstitute/cjl_DEPRECATED
Deprecation errors for DB configs. Closes #2186 |
69a8d21
|
|||
|
|
cjllanwarne |
JES in-command write_lines fixup
|
All checks have passed4 successful checks |
8f6ee41
|
||
|
|
Horneth |
Execution Store and JobPaths optimizations (#2198)
* Limit JobPaths creation and Improve execution store performance * Fix subworkflow paths * PR comments |
4a49f93
|
|||
|
|
cjllanwarne |
Merge pull request #2191 from broadinstitute/cjl_write_lines_jes
JES in-command write_lines fixup. Closes #1906 |
05ec820
|
Commits on Apr 26, 2017
|
|
cjllanwarne |
Cromwell's failure is now complete
|
Some checks were not successful1 failing and 3 successful checks |
50375c7
|
||
|
|
cjllanwarne |
Merge pull request #2203 from broadinstitute/cjl_consistent_failure
Cromwell's failure is now complete (develop edition). Closes #2201 |
5360704
|
|||
|
|
Horneth |
Tweak retries (#2208)
* tweak retries * PR comments |
cf37252
|
Commits on Apr 27, 2017
|
|
Horneth |
Use io dispatcher (#2206)
* Use io dispatcher * PR comments |
c89c83f
|
Commits on Apr 28, 2017
|
|
cjllanwarne |
Remove unneeded SubWorkflowStoreCompleteSuccess message
|
All checks have passed4 successful checks |
336d4f6
|
Commits on Apr 29, 2017
|
|
Horneth |
JSON auth for Google SA (#2213)
* JSON auth for Google SA * deprecation warning for pem files |
e316d8d
|
|||
|
|
cjllanwarne |
Merge pull request #2218 from broadinstitute/cjl_remove_SubWorkflowSt…
…oreCompleteSuccess Remove unneeded SubWorkflowStoreCompleteSuccess message. Closes #2185 |
d54c313
|
Commits on May 01, 2017
|
|
cjllanwarne |
Bring in validation messages from WDL4S
|
All checks have passed4 successful checks |
ea5f989
|
||
|
|
cjllanwarne |
Merge pull request #2214 from broadinstitute/cjl_better_validation_me…
…ssages Bring in validation messages from WDL4S. Closes #2211 |
fceeedf
|
Commits on May 02, 2017
|
|
mcovarr + mcovarr |
Batching Job Store simpleton writes.
|
7263b5e
|
|||
|
|
cjllanwarne |
Removing semicolon from migration query
|
Some checks were not successful2 errored and 1 pending checks |
aaa64d7
|
||
|
|
cjllanwarne |
Merge pull request #2231 from broadinstitute/cjl_remove_semicolons_de…
…velop Removing semicolon from migration query (develop edition) |
f094129
|
Commits on May 03, 2017
|
|
danbills + geoffjentry |
adding Dan Billings to pull approve list (#2240)
|
a4d4616
|
|||
|
|
jsotobroad |
JobStoreSimpletonMigration was putting quotation marks around file va…
…lues which caused the jobs to fail once cromwell recovered after a migration |
All checks have passed4 successful checks |
f999719
|
||
|
|
Horneth |
use the right failureMode value (#2239)
|
98e0e6e
|
Commits on May 04, 2017
|
|
cjllanwarne |
Akka HTTP bump
|
All checks have passed4 successful checks |
c8e9c94
|
||
|
|
cjllanwarne |
Merge pull request #2245 from broadinstitute/cjl_akka_http_10.0.6
Akka HTTP bump |
834aaa0
|
Commits on May 05, 2017
|
|
mcovarr + mcovarr |
Batch writes of call caching related data.
|
46bd6fe
|
|||
|
|
cjllanwarne |
WDL4S bump
|
b8574c1
|
|||
|
|
jsotobroad |
Merge pull request #2242 from broadinstitute/js_job_store_extra_quota…
…tion_develop JobStoreSimpletonMigration was putting quotation marks around file values which caused the jobs to fail once cromwell recovered after a migration |
c3d8f6c
|
Commits on May 07, 2017
|
|
cjllanwarne |
Merge pull request #2247 from broadinstitute/cjl_wdl4s_bump
WDL4S bump |
a046dfe
|
Commits on May 08, 2017
|
|
jsotobroad |
Double Quoted file inputs cause PipelineAPI workflows to run forever. C…
|
496c4f6
|
Commits on May 10, 2017
|
|
Horneth |
Call Caching v3 (#2243)
* Call Caching revamp * add chahgelog * fix test + changelog * update changelog * custom centaur * cleanup * create directories before copy and write on SFS * tweak runnable calls * oops * fix test * PR comments * minor migration fix * PR comments * fix * PR comments * centaur develop |
11abb7f
|
|||
|
|
Horneth |
Allow for tag + digest docker images (#2255)
* allow for tag + digest docker images * PR comments |
aab4763
|
Commits on May 12, 2017
|
|
Horneth |
add conf
(cherry picked from commit c14e64d) |
1d4e0ab
|
|||
|
|
jsotobroad |
Readme Link Fixes (#2259)
Fix a few links in README |
1a131c1
|
Commits on May 15, 2017
|
|
Horneth |
update changelog to reflect reality (#2263)
|
5bb2875
|
Commits on May 17, 2017
|
|
Horneth |
Add task to release wdl to make a github release (#2275)
* Add task to release wdl to make a github release * add -x * wrong organization * shellchecked |
199b1d9
|
Commits on May 18, 2017
|
|
Horneth |
update changelog again (#2272)
* update changelog again * fix space |
cd4059b
|
Commits on May 19, 2017
|
|
antonkulaga + Horneth |
fix for #2256 (#2280)
This PR fixes #2256 by overriding default entry-point with /bin/bash |
ddf223d
|
Commits on May 22, 2017
|
|
danbills |
tested read lines
|
4ac640b
|
Commits on May 23, 2017
|
|
ruchim |
Allow customLabels submission to Cromwell Client (#2257)
allow customLabels submission through CromwellClient |
693cda5
|
|||
|
|
ruchim |
wow (#2290)
|
425cde2
|
|||
|
|
danbills |
added tests for all read functions
|
Some checks were not successful1 failing and 1 pending checks |
0be7611
|
||
|
|
danbills |
tidy up the read_X code
|
e34957f
|
|||
|
|
ruchim |
Query using Labels (#2253)
added querying through labels |
091ed3b
|
|||
|
|
jsotobroad |
validation of input gcs file paths that start with \" (#2271)
* validateworkflow input gcs file paths that start with \" |
e79e081
|
|||
|
|
cjllanwarne |
Bringing map to pair coercion and basename from WDL4S
|
All checks have passed4 successful checks |
948efa5
|
Commits on May 24, 2017
|
|
Horneth |
Consume http response and re-synchronize token and manifest (#2287)
* consume http response and re-synchronize token and manifest * remove irrelevant comment * PR comments |
34323f0
|
|||
|
|
Horneth |
Update google nio + small optimization for copy workflow outputs (#2277)
* upgrade gcs nio version * remove retry settings * fix up copy workflow outputs * PR comments |
2c64afc
|
|||
|
|
Horneth |
fix
|
f673cc8
|
|||
|
|
cjllanwarne |
Merge pull request #2274 from broadinstitute/cjl_coerce_map_to_pairs
Bringing map to pair coercion and basename from WDL4S |
81d5945
|
|||
|
|
danbills |
added ability to configure read X limits
|
96b33e5
|
|||
|
|
danbills |
Merge branch 'develop' into db_read_limits
|
52c6faa
|
Commits on May 25, 2017
|
|
Horneth + mcovarr |
Workflow Docker Hashing.
|
38b52a3
|
|||
|
|
danbills |
added README and CHANGELOG comments
|
45ca36d
|
|||
|
|
danbills |
formatting
|
607a1d0
|
|||
|
|
danbills |
Merge pull request #2291 from danbills/db_read_limits
added read limits to read_X functions |
06d3f11
|
Commits on May 26, 2017
|
|
Horneth |
fix release wdl and custom label summarizing (#2298)
|
b30a232
|
Commits on May 30, 2017
|
|
Horneth |
Update mysql and jackson-databind dependencies (#2299)
* update mysql and jackson-databind dependencies * update jackson-module-scala version |
1312eb3
|
|||
|
|
Horneth |
Update cromwell version to 27
|
1b7c65f
|
|||
|
|
Horneth |
Update cromwell version from 27 to 28
|
4327ca6
|
Commits on Jun 01, 2017
|
|
ruchim |
Preliminary validation of workflow options (#2295)
preliminary validation of wf options before WorkflowID creation |
98d766b
|
|||
|
|
mcovarr + mcovarr |
Purge workflow store entry before job entries.
|
bb96682
|
Commits on Jun 05, 2017
|
|
adamstruck + ruchim |
catching up backend to the TES schema (#2293)
added google storage support, let TES handle creating the command script, updated funnel commit for centaur tests |
44ba3df
|
Commits on Jun 06, 2017
|
|
Horneth |
Add retries to credential validation (#2314)
* works? * PR comments * rebase * oops |
6fbeadc
|
Commits on Jun 08, 2017
|
|
mcovarr + mcovarr |
jfrog
|
4487a51
|
Commits on Jun 09, 2017
|
|
Horneth |
honor allow result reuse (#2341) (#2349)
(cherry picked from commit 461cff2) |
ac3d65e
|
Commits on Jun 12, 2017
|
|
mcovarr + mcovarr |
First pass of workflow type and version. This takes parameters on RES…
…T endpoints, roundtrips to the workflow store, and publishes to metadata. Currently hardcodes type and version for the command line. |
ef012a6
|
|||
|
|
mcovarr + mcovarr |
Remove some user-facing WDL specificity.
|
c0289dc
|
|||
|
|
mcovarr + mcovarr |
Make workflow type optional in store, remove references to WDL in Swa…
…gger. |
6551129
|
Commits on Jun 13, 2017
|
|
mcovarr |
oops
|
bf3202d
|
Commits on Jun 15, 2017
|
|
mcovarr + mcovarr |
Don't implicitly add a library/ repo prefix to Docker images as that …
…breaks 26-era call caches. |
f3e04bf
|
|||
|
|
Horneth |
Config option to disable copying of outputs on cache hit for JES (#2347)
* Add support for copyless call caching in JES |
46ad512
|
Commits on Jun 20, 2017
|
|
Horneth |
conf fix
|
151bf05
|
|||
|
|
Horneth |
Call Caching Diff Endpoint (#2363)
* Call Caching Diff Endpoint |
3801e14
|
Commits on Jun 21, 2017
|
|
ruchim |
deprecated image (#2370)
|
1f166d9
|
Commits on Jun 22, 2017
|
|
Horneth |
Add version endpoint to Cromwell client (#2368)
* add version endpoint to Cromwell client * add version endpoint to Cromwell client |
1394bdd
|
|||
|
|
mcovarr + mcovarr |
only check stderr if failOnStderr is true
|
90f1e17
|
Commits on Jun 23, 2017
|
|
mcovarr + mcovarr |
Make an effort to diagnose bad bucket names.
|
931f62e
|
Commits on Jun 26, 2017
|
|
mcovarr + mcovarr |
Some magic to work with the new Travis Trusty images.
|
9660633
|
Commits on Jun 27, 2017
|
|
ruchim |
Gather completed shards (#2376)
* fail slow fixup, and adding scatter collectorkey to ExecutionStoreBenchmark test |
c99856a
|
|||
|
|
ruchim |
Add Labels (#2357)
* add label manager actor, prelim tests and swagger updates, changelog updates and docs |
65d1849
|
|||
|
|
Horneth |
Return 404 on CC Endpoint for old workflows + cleanup from previous v…
…ersion (#2372) * update changelog / readme and return 404 for old workflows |
f71f598
|
Commits on Jun 28, 2017
|
|
mcovarr + mcovarr |
Sanify the default metadata batch write size.
|
477faa4
|
Commits on Jun 29, 2017
|
|
Horneth |
Cromwell restart (#2386)
* Centaur Restart |
5fa488e
|
|||
|
|
jsotobroad |
add launch integration test capability with cron / build notifications (
#2375) * add ability to launch integration tests through cron job in travis * add notification to all builds through slack |
7422714
|
|||
|
|
mcovarr + mcovarr |
Bump to newliney wdl4s, document this user-visible change.
|
8962b78
|
|||
|
|
Horneth |
fix wdltool release (#2393)
|
031d9b1
|
|||
|
|
jsotobroad + Horneth |
add eventually to WorkflowStoreAactorSpec encrypted workflow options …
…test (#2395) |
a33f74a
|
Commits on Jun 30, 2017
|
|
ruchim |
Changed Label Formatting (#2389)
Modify Cromwell label expectations |
553ab31
|
|||
|
|
ruchim |
travis tweaks (#2397)
* tone down travis slack notifications |
e75afe4
|
|||
|
|
ruchim |
28 Changelog (#2398)
final additions to changelog |
3769c06
|
|||
|
|
Horneth |
Update cromwell version to 28
|
f63a9e6
|
|||
|
|
Horneth |
Update cromwell version from 28 to 29
|
7c9641c
|
|||
|
|
Horneth |
update release WDL (#2399)
|
635733c
|
Commits on Jul 01, 2017
|
|
geoffjentry |
Migrate Cromwell from Spray to Akka HTTP. Closes #1243 (#2380)
|
176de92
|
Commits on Jul 05, 2017
|
|
geoffjentry |
Scala 2.12 support for Cromwell (#2412)
|
3e98082
|
Commits on Jul 06, 2017
|
|
Horneth + geoffjentry |
Rebased (#2406)
|
a30c701
|
|||
|
|
mcovarr + mcovarr |
Remove pre-PBE tables.
|
13691aa
|
|||
|
|
mcovarr + mcovarr |
Command line parsing redo.
|
308f087
|
Commits on Jul 07, 2017
|
|
geoffjentry |
Only gzip metadata if requested. Closes #2419 (#2427)
* Only gzip metadata if requested. Closes #2419 |
644967d
|
Commits on Jul 11, 2017
|
|
mcovarr + mcovarr |
patvars
|
6d00a45
|
Commits on Jul 12, 2017
|
|
mcovarr + mcovarr |
make console usable again
|
1b958d2
|
|||
|
|
geoffjentry |
Add restrict-metadata-access (#2435)
Add restrict-metadata-access |
2862235
|
Commits on Jul 14, 2017
|
|
francares |
Fixed issue regarding parsing request body on query POST API. (#2447)
|
2e32c41
|
Commits on Jul 17, 2017
|
|
mcovarr + mcovarr |
Separate out retryables from true terminals from the WEA perspective.
|
8c0f888
|
|||
|
|
kshakir |
Removed /api prefix from /engine.
|
All checks have passed4 successful checks |
9e688ec
|
||
|
|
cjllanwarne |
Preempted to backendStatus in existing metadata.
|
c5adbf2
|
Commits on Jul 18, 2017
|
|
kshakir |
Merge pull request #2454 from broadinstitute/ks_move_version_endpoint
Removed /api prefix from /engine. |
947f8c6
|
|||
|
|
cjllanwarne |
Merge pull request #2443 from broadinstitute/cjl_2438
Preempted to backendStatus in existing metadata. Develop edition |
1786ae5
|
|||
|
|
kshakir |
Docker publish develop branch to dev environment.
|
All checks have passed4 successful checks |
2e9a96e
|
||
|
|
kshakir |
Merge pull request #2465 from broadinstitute/ks_docker_tag_caas
Docker publish develop branch to dev environment. |
b32a8fe
|
|||
|
|
mcovarr + mcovarr |
Update to beginning-cromwomified, subprojecty wdl4s.
|
2708188
|
|||
|
|
mcovarr + mcovarr |
Updated wdl4s
|
9620f74
|
Commits on Jul 19, 2017
|
|
cjllanwarne |
Resurrected the unused `Preempted` status
|
All checks have passed4 successful checks |
fd05a87
|
||
|
|
cjllanwarne |
Merge pull request #2462 from broadinstitute/cjl_2455
Resurrected the unused `Preempted` status |
9b08454
|
Commits on Jul 20, 2017
|
|
geoffjentry |
Assign a dispatcher to services and allow them to be customized (#2470)
|
eece7ae
|
|||
|
|
cjllanwarne |
Made 'size' accept empty files, Cromwell-side
|
Some checks were not successful2 errored and 1 successful checks |
9cf69ad
|
||
|
|
cjllanwarne |
Merge pull request #2468 from broadinstitute/cjl_optional_file_size
Made 'size' accept empty files, Cromwell-side |
0b92711
|
|||
|
|
cjllanwarne |
Made call cache hash endpoint more JSONic
|
All checks have passed4 successful checks |
32841b9
|
||
|
|
cjllanwarne |
Merge pull request #2471 from broadinstitute/cjl_reformat_ccdiff
Made call cache hash endpoint more JSONic |
f1ee2d2
|
|||
|
|
cjllanwarne |
Diff endpoint doc'ing
|
All checks have passed4 successful checks |
9225bc5
|
||
|
|
cjllanwarne |
Merge pull request #2473 from broadinstitute/cjl_diff_docs
Diff endpoint doc'ing |
8a8ed40
|
Commits on Jul 22, 2017
|
|
danbills |
Pull approve v2 featuring GH review integration (#2477)
bumped pullapprove to v2 and added GH reviews |
36a08ec
|
|||
|
|
kshakir |
Switch from travis encrypted files to vault
|
All checks have passed4 successful checks |
d5a51c6
|
Commits on Jul 24, 2017
|
|
kshakir |
Merge pull request #2481 from broadinstitute/ks_test_docker_vault
Switch from travis encrypted files to vault. Closes #1296 |
be6ad40
|
|||
|
|
geoffjentry |
Put the binding timeout back to where it was in spray-land (#2478)
|
11496fc
|
Commits on Jul 25, 2017
|
|
ruchim |
Don't append to lists (#2485) (#2486)
append metadata events to a vector not list |
49b59b0
|
Commits on Jul 26, 2017
|
|
kshakir |
Initialize db before serving over HTTP
|
All checks have passed4 successful checks |
76f6aae
|
||
|
|
kshakir |
Merge pull request #2484 from broadinstitute/ks_liquibase_then_bind
Initialize db before serving over HTTP |
5b16d61
|
|||
|
|
Horneth |
Handle failed Cromwell requests (#2488)
* Handle failed Cromwell requests in the CromwellAPIClient |
27f9f1c
|
|||
|
|
danbills |
removed jainh from committers to fix pullapprove (#2491)
|
219b0c5
|
|||
|
|
Horneth |
Handle null access token from Google Credentials (#2489)
* handle null access token from Google Credentials |
645d8b2
|
Commits on Jul 27, 2017
|
|
cjllanwarne |
Additional clienty bits for Cromwell
|
bdfaf91
|
|||
|
|
cjllanwarne |
Merge pull request #2474 from broadinstitute/cjl_more_clienty_bits
Additional clienty bits for Cromwell |
16a7498
|
|||
|
|
mcovarr + mcovarr |
Updates for subprojected wdl4s. Also remove "dryRun" since that didn'…
…t actually dry run anything. |
bb0f6ea
|
|||
|
|
mcovarr + mcovarr |
search and replace run amok
|
e648273
|
Commits on Jul 28, 2017
|
|
geoffjentry |
Upgrade to scala 2.12.3 (#2502)
|
42a1dce
|
|||
|
|
cjllanwarne |
Model objects for Cromwell Queries
|
All checks have passed4 successful checks |
4d8825d
|
||
|
|
cjllanwarne |
Merge pull request #2501 from broadinstitute/cjl_query_responses
Model objects for Cromwell Queries |
c041402
|
|||
|
|
cjllanwarne |
Allow "AbortedResponse" even when not aborting
|
All checks have passed4 successful checks |
350a024
|
||
|
|
cjllanwarne |
Merge pull request #2503 from broadinstitute/cjl_jes_6_day_limit
Allow "AbortedResponse" even when not aborting |
e642a94
|
Commits on Jul 30, 2017
|
|
geoffjentry |
Dispatcherizing undispatcherized actors. Trying to standardize on add…
…ing it to the props where appropriate (#2499) |
a611db6
|
Commits on Jul 31, 2017
|
|
kshakir |
Replaced use of Future.foreach with error handling
|
All checks have passed4 successful checks |
8d3e615
|
||
|
|
kshakir |
Merge pull request #2500 from broadinstitute/ks_report_bad_inputs
Replaced use of Future.foreach with error handling |
0e4d507
|
Commits on Aug 01, 2017
|
|
Horneth |
Graceful Server Shutdown (#2490)
* Graceful shutdown * Dont overwrite jes auth file include application.conf in centaur conf files |
07a5671
|
|||
|
|
kshakir |
Client only modifies request json when inserting a refresh token.
|
All checks have passed4 successful checks |
cf8c228
|
||
|
|
kshakir |
Merge pull request #2509 from broadinstitute/ks_client_pass_options
Client only modifies request json when inserting a refresh token. |
e97bcc7
|
Unified
Split
Showing
528 changed files
with
15,087 additions
and 9,113 deletions.
View
2
.idea/inspectionProfiles/Project_Default.xml
| @@ -3,4 +3,4 @@ | ||
| <option name="myName" value="Project Default" /> | ||
| <inspection_tool class="TypeAnnotation" enabled="false" level="WARNING" enabled_by_default="false" /> | ||
| </profile> | ||
| -</component> | ||
| +</component> | ||
View
23
.pullapprove.yml
| @@ -1,19 +1,28 @@ | ||
| -approve_by_comment: true | ||
| -approve_regex: ':\+1:' | ||
| -reset_on_push: false | ||
| -author_approval: ignored | ||
| -reviewers: | ||
| +# enabling version 2 turns github reviews on by default | ||
| +version: 2 | ||
| +group_defaults: | ||
| + approve_by_comment: | ||
| + enabled: true | ||
| + approve_regex: ':\+1:' | ||
| + reset_on_push: | ||
| + enabled: false | ||
| +groups: | ||
| + reviewers: | ||
| required: 2 | ||
| - members: | ||
| + github_reviews: | ||
| + enabled: true | ||
| + author_approval: | ||
| + ignored: true | ||
| + users: | ||
| - Horneth | ||
| - cjllanwarne | ||
| - francares | ||
| - gauravs90 | ||
| - geoffjentry | ||
| - - jainh | ||
| - jsotobroad | ||
| - katevoss | ||
| - kcibul | ||
| - kshakir | ||
| - mcovarr | ||
| - ruchim | ||
| + - danbills |
View
17
.travis.yml
| @@ -1,8 +1,10 @@ | ||
| sudo: required | ||
| dist: trusty | ||
| +services: | ||
| + - docker | ||
| language: scala | ||
| scala: | ||
| - - 2.11.8 | ||
| + - 2.12.2 | ||
| jdk: | ||
| - oraclejdk8 | ||
| cache: | ||
| @@ -16,10 +18,12 @@ before_cache: | ||
| - find $HOME/.ivy2 -name "ivydata-*.properties" -delete | ||
| - find $HOME/.sbt -name "*.lock" -delete | ||
| before_install: | ||
| - - openssl aes-256-cbc -K "$encrypted_5ebd3ff04788_key" -iv "$encrypted_5ebd3ff04788_iv" -in src/bin/travis/resources/jesConf.tar.enc -out jesConf.tar -d || true | ||
| + # https://github.com/travis-ci/travis-ci/issues/7940#issuecomment-310759657 | ||
| + - sudo rm -f /etc/boto.cfg | ||
| env: | ||
| global: | ||
| - CENTAUR_BRANCH=develop | ||
| + - INTEGRATION_TESTS_DIR=src/main/resources/integrationTestCases | ||
| matrix: | ||
| # Setting this variable twice will cause the 'script' section to run twice with the respective env var invoked | ||
| - BUILD_TYPE=sbt | ||
| @@ -36,3 +40,12 @@ deploy: | ||
| script: src/bin/travis/publishRelease.sh | ||
| on: | ||
| tags: true | ||
| +notifications: | ||
| + slack: | ||
| + rooms: | ||
| + - secure: B5KYcnhk/ujAUWlHsjzP7ROLm6MtYhaGikdYf6JYINovhMbVKnZCTlZEy7rqT3L2T5uJ25iefD500VQGk1Gn7puQ1sNq50wqjzQaj20PWEiBwoWalcV/nKBcQx1TyFT13LJv8fbFnVPxFCkC3YXoHedx8qAhDs8GH/tT5J8XOC8= | ||
| + template: | ||
| + - "Build <%{build_url}|#%{build_number}> (<%{compare_url}|%{commit}>) of %{repository}@%{branch} by %{author} %{result} in %{duration}" | ||
| + on_success: change | ||
| + on_failure: change | ||
| + on_pull_requests: false | ||
View
252
CHANGELOG.md
| @@ -1,5 +1,246 @@ | ||
| # Cromwell Change Log | ||
| +## 29 | ||
| + | ||
| +### Breaking Changes | ||
| + | ||
| +* Request timeouts for HTTP requests on the REST API now return a 503 status code instead of 500. The response for a request timeout is no longer in JSON format. | ||
| +* The metadata endpoint no longer returns gzipped responses by default. This now needs to be explicitly requested with an `Accept-Encoding: gzip` header | ||
| + | ||
| +* Command line usage has been extensively revised for Cromwell 29. Please see the | ||
| +[README](https://github.com/broadinstitute/cromwell#command-line-usage) for details. | ||
| + | ||
| +* The engine endpoints are now served under `/engine`. Previousely engine endpoints were available under | ||
| +`/api/engine`. Workflow endpoints are still served under `/api/workflows`. The setting `api.routeUnwrapped` has been | ||
| +retired at the same time. | ||
| + | ||
| +* The response format of the [callcaching/diff](https://github.com/broadinstitute/cromwell#get-apiworkflowsversioncallcachingdiff) endpoint has been updated. | ||
| + | ||
| +### Cromwell Server | ||
| + | ||
| +* Cromwell now attempts to gracefully shutdown when running in server mode and receiving a `SIGINT` (`Ctrl-C`) or `SIGTERM` (`kill`) signal. This includes waiting for all pending Database writes before exiting. | ||
| +A detailed explanation and information about how to configure this feature can be found in the [Cromwell Wiki](https://github.com/broadinstitute/cromwell/wiki/DevZone#graceful-server-shutdown). | ||
| + | ||
| +## 28 | ||
| + | ||
| +### Bug Fixes | ||
| + | ||
| +#### WDL write_* functions add a final newline | ||
| + | ||
| +The following WDL functions now add a newline after the final line of output (the previous behavior of not adding this | ||
| +newline was inadvertent): | ||
| +- `write_lines` | ||
| +- `write_map` | ||
| +- `write_object` | ||
| +- `write_objects` | ||
| +- `write_tsv` | ||
| + | ||
| +For example: | ||
| + | ||
| +``` | ||
| +task writer { | ||
| + Array[String] a = ["foo", "bar"] | ||
| + command { | ||
| + # used to output: "foo\nbar" | ||
| + # now outputs: "foo\nbar\n" | ||
| + cat write_lines(a) | ||
| + } | ||
| +} | ||
| +``` | ||
| + | ||
| +#### `ContinueWhilePossible` | ||
| + | ||
| +A workflow utilizing the WorkflowFailureMode Workflow Option `ContinueWhilePossible` will now successfully reach a terminal state once all runnable jobs have completed. | ||
| +#### `FailOnStderr` | ||
| +When `FailOnStderr` is set to false, Cromwell no longer checks for the existence of a stderr file for that task. | ||
| + | ||
| +### WDL Functions | ||
| + | ||
| +#### New functions: floor, ceil and round: | ||
| + | ||
| +Enables the `floor`, `ceil` and `round` functions in WDL to convert floating point numbers to integers. | ||
| + | ||
| +For example we can now use the size of an input file to influence the amount of memory the task is given. In the example below a 500MB input file will result in a request for a VM with 2GB of memory: | ||
| + | ||
| +``` | ||
| +task foo { | ||
| + File in_file | ||
| + command { ... } | ||
| + runtime { | ||
| + docker: "..." | ||
| + memory: ceil(size(in_file)) * 4 | ||
| + } | ||
| +} | ||
| +``` | ||
| + | ||
| +### Call Caching | ||
| + | ||
| +* Hash values calculated by Cromwell for a call when call caching is enabled are now published to the metadata. | ||
| +It is published even if the call failed. However if the call is attempted multiple times (because it has been preempted for example), | ||
| +since hash values are strictly identical for all attempts, they will only be published in the last attempt section of the metadata for this call. | ||
| +If the hashes fail to be calculated, the reason is indicated in a `hashFailures` field in the `callCaching` section of the call metadata. | ||
| +*Important*: Hashes are not retroactively published to the metadata. Which means only workflows run on Cromwell 28+ will have hashes in their metadata. | ||
| + | ||
| +See the [README](https://github.com/broadinstitute/cromwell#get-apiworkflowsversionidmetadata) for an example metadata response. | ||
| + | ||
| +* New endpoint returning the hash differential for 2 calls. | ||
| + | ||
| +`GET /api/workflows/:version/callcaching/diff` | ||
| + | ||
| +See the [README](https://github.com/broadinstitute/cromwell#get-apiworkflowsversioncallcachingdiff) for more details. | ||
| + | ||
| +### Workflow Submission | ||
| + | ||
| +* The workflow submission parameters `wdlSource` and `wdlDependencies` have been deprecated in favor of `workflowSource` and | ||
| +`workflowDependencies` respectively. The older names are still supported in Cromwell 28 with deprecation warnings but will | ||
| +be removed in a future version of Cromwell. | ||
| + | ||
| +### Labels | ||
| +* A new `/labels` endpoint has been added to update labels for an existing workflow. See the [README](README.md#patch-apiworkflowsversionidlabels) for more information. | ||
| +* Label formatting requirements have been updated, please check the [README](README.md#label-format) for more detailed documentation. | ||
| + | ||
| + | ||
| +### JES Backend | ||
| + | ||
| +The JES backend now supports a `filesystems.gcs.caching.duplication-strategy` configuration entry. | ||
| +It can be set to specify the desired behavior of Cromwell regarding call outputs when a call finds a hit in the cache. | ||
| +The default value is `copy` which will copy all output files to the new call directory. | ||
| +A second value is allowed, `reference`, that will instead point to the original output files, without copying them. | ||
| + | ||
| + | ||
| +```hocon | ||
| +filesystems { | ||
| + gcs { | ||
| + auth = "application-default" | ||
| + | ||
| + caching { | ||
| + duplication-strategy = "reference" | ||
| + } | ||
| + } | ||
| +} | ||
| +``` | ||
| + | ||
| +A placeholder file will be placed in the execution folder of the cached call to explain the absence of output files and point to the location of the original ones. | ||
| + | ||
| + | ||
| +### Metadata Write Batching | ||
| + | ||
| +Metadata write batching works the same as in previous versions of Cromwell, but the default batch size has been changed from 1 to 200. It's possible that 200 is too high in some environments, but 200 is more likely to be an appropriate value | ||
| +than the previous default. | ||
| + | ||
| + | ||
| +## 27 | ||
| + | ||
| +### Migration | ||
| + | ||
| +* Call Caching has been improved in this version of Cromwell, specifically the time needed to determine whether or not a job can be cached | ||
| + has drastically decreased. To achieve that the database schema has been modified and a migration is required in order to preserve the pre-existing cached jobs. | ||
| + This migration is relatively fast compared to previous migrations. To get an idea of the time needed, look at the size of your `CALL_CACHING_HASH_ENTRY` table. | ||
| + As a benchmark, it takes 1 minute for a table with 6 million rows. | ||
| + The migration will only be executed on MySQL. Other databases will lose their previous cached jobs. | ||
| + In order to run properly on MySQL, **the following flag needs to be adjusted**: https://dev.mysql.com/doc/refman/5.5/en/server-system-variables.html#sysvar_group_concat_max_len | ||
| + The following query will give you a minimum to set the group_concat_max_len value to: | ||
| + | ||
| + ```sql | ||
| +SELECT MAX(aggregated) as group_concat_max_len FROM | ||
| + ( | ||
| + SELECT cche.CALL_CACHING_ENTRY_ID, SUM(LENGTH(CONCAT(cche.HASH_KEY, cche.HASH_VALUE))) AS aggregated | ||
| + FROM CALL_CACHING_HASH_ENTRY cche | ||
| + GROUP BY cche.CALL_CACHING_ENTRY_ID | ||
| + ) aggregation | ||
| + ``` | ||
| + | ||
| + Here is the SQL command to run to set the group_concat_max_len flag to the proper value: | ||
| + | ||
| + ```sql | ||
| +SET GLOBAL group_concat_max_len = value | ||
| + ``` | ||
| + | ||
| + Where `value` is replaced with the value you want to set it to. | ||
| + | ||
| + Note that the migration will fail if the flag is not set properly. | ||
| + | ||
| +### Breaking Changes | ||
| + | ||
| +* The update to Slick 3.2 requires a database stanza to | ||
| +[switch](http://slick.lightbend.com/doc/3.2.0/upgrade.html#profiles-vs-drivers) from using `driver` to `profile`. | ||
| + | ||
| +```hocon | ||
| +database { | ||
| + #driver = "slick.driver.MySQLDriver$" #old | ||
| + profile = "slick.jdbc.MySQLProfile$" #new | ||
| + db { | ||
| + driver = "com.mysql.jdbc.Driver" | ||
| + url = "jdbc:mysql://host/cromwell?rewriteBatchedStatements=true" | ||
| + user = "user" | ||
| + password = "pass" | ||
| + connectionTimeout = 5000 | ||
| + } | ||
| +} | ||
| +``` | ||
| + | ||
| +### Call Caching | ||
| + | ||
| +Cromwell now supports call caching with floating Docker tags (e.g. `docker: "ubuntu:latest"`). Note it is still considered | ||
| +a best practice to specify Docker images as hashes where possible, especially for production usages. | ||
| + | ||
| +Within a single workflow Cromwell will attempt to resolve all floating tags to the same Docker hash, even if Cromwell is restarted | ||
| +during the execution of a workflow. In call metadata the `docker` runtime attribute is now the same as the | ||
| +value that actually appeared in the WDL: | ||
| + | ||
| +``` | ||
| + "runtimeAttributes": { | ||
| + "docker": "ubuntu:latest", | ||
| + "failOnStderr": "false", | ||
| + "continueOnReturnCode": "0" | ||
| + } | ||
| +``` | ||
| + | ||
| +Previous versions of Cromwell rewrote the `docker` value to the hash of the Docker image. | ||
| + | ||
| +There is a new call-level metadata value `dockerImageUsed` which captures the hash of the Docker image actually used to | ||
| +run the call: | ||
| + | ||
| +``` | ||
| + "dockerImageUsed": "library/ubuntu@sha256:382452f82a8bbd34443b2c727650af46aced0f94a44463c62a9848133ecb1aa8" | ||
| +``` | ||
| + | ||
| +### Docker | ||
| + | ||
| +* The Docker section of the configuration has been slightly reworked | ||
| +An option to specify how a Docker hash should be looked up has been added. Two methods are available. | ||
| + "local" will try to look for the image on the machine where cromwell is running. If it can't be found, Cromwell will try to `pull` the image and use the hash from the retrieved image. | ||
| + "remote" will try to look up the image hash directly on the remote repository where the image is located (Docker Hub and GCR are supported) | ||
| +Note that the "local" option will require docker to be installed on the machine running cromwell, in order for it to call the docker CLI. | ||
| +* Adds hash lookup support for public [quay.io](https://quay.io/) images. | ||
| + | ||
| +### WDL Feature Support | ||
| +* Added support for the new WDL `basename` function. Allows WDL authors to get just the file name from a File (i.e. removing the directory path) | ||
| +* Allows coercion of `Map` objects into `Array`s of `Pair`s. This also allows WDL authors to directly scatter over WDL `Map`s. | ||
| + | ||
| +### Miscellaneous | ||
| +* Adds support for JSON file format for google service account credentials. As of Cromwell 27, PEM credentials for PAPI are deprecated and support might be removed in a future version. | ||
| + | ||
| +``` | ||
| +google { | ||
| + | ||
| + application-name = "cromwell" | ||
| + | ||
| + auths = [ | ||
| + { | ||
| + name = "service-account" | ||
| + scheme = "service_account" | ||
| + json-file = "/path/to/file.json" | ||
| + } | ||
| + ] | ||
| +} | ||
| +``` | ||
| + | ||
| +### General Changes | ||
| + | ||
| +* The `/query` endpoint now supports querying by `label`. See the [README](README.md#get-apiworkflowsversionquery) for more information. | ||
| +* The `read_X` standard library functions limit accepted filesizes. These differ by type, e.g. read_bool has a smaller limit than read_string. See reference.conf for default settings. | ||
| + | ||
| ## 26 | ||
| ### Breaking Changes | ||
| @@ -43,17 +284,6 @@ system.io { | ||
| } | ||
| ``` | ||
| -* Added a `script-epilogue` configuration option to adjust the logic that runs at the end of the scripts which wrap call executions. | ||
| - This option is adjustable on a per-backend basis. If unspecified, the default value is `sync`. | ||
| - | ||
| -### WDL Features | ||
| - | ||
| -With Cromwell 26, Cromwell will support `if x then y else z` expressions (see: https://github.com/broadinstitute/wdl/blob/develop/SPEC.md#if-then-else). For example: | ||
| -``` | ||
| -Boolean b = true | ||
| -String s = if b then "value if True" else "value if False" | ||
| -``` | ||
| - | ||
| ## 25 | ||
| ### External Contributors | ||
View
4
NOTICE
| @@ -1,4 +0,0 @@ | ||
| -cromwell.webservice/PerRequest.scala (https://github.com/NET-A-PORTER/spray-actor-per-request) | ||
| -is distributed with this software under the Apache License, Version 2.0 (see the LICENSE-ASL file). In accordance | ||
| -with that license, that software comes with the following notices: | ||
| - Copyright (C) 2011-2012 Ian Forsey |
Oops, something went wrong.