Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Should metadata endpoint be forcing gzip on users? #2419
Comments
TMiguelT
commented
Jul 6, 2017
|
Agreed. As a user, I found this behaviour very strange, especially considering the other endpoints return uncompressed responses |
geoffjentry
added a commit
that referenced
this issue
Jul 6, 2017
|
|
geoffjentry |
681c5a6
|
geoffjentry
added a commit
that referenced
this issue
Jul 6, 2017
|
|
geoffjentry |
25cd481
|
geoffjentry
closed this
in 644967d
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
geoffjentry commentedJul 5, 2017
A while back we changed things to return gzipped content in the metadata endpoint by default, despite what the client says it can handle. generally the client should be telling the server what it can expect and the server either handles it appropriately or returns a 415.
I think that we should switch this to encoding on request. The downside is that there might be users who would be much better off getting a gzipped response but not realizing they have to do something extra (depending on their client).