Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdltool should report optionals (even with defaults) #2532

Open
cjllanwarne opened this issue Aug 9, 2017 · 3 comments

Comments

@cjllanwarne
Copy link
Contributor

commented Aug 9, 2017

#When wdltool generates an inputs JSON, you want to include all required and optional values, even if the optional values have defaults. For example:

workflow foo {
  Int a
  Int b = 5
  Int? c
  Int? d = 5
  Int e = a + b
  Int? f = a + b # Not sure how to handle this one
}

Should create inputs, something like this (not 100% sure of the format it creates):

{
  "foo.a": "Int"
  "foo.c": "Int?"
  "foo.d": "Int? with default"
  "foo.f": "Int? with default"
}

The handling of e and f is probably why this has been punted until now.

@LeeTL1220

This comment has been minimized.

Copy link

commented Aug 9, 2017

@cjllanwarne Yes, my money is that you have pegged this exactly. I would love this update. I prefer the Int? mem=4 for specifying default values. Otherwise, we have to pepper our command and runtime blocks with ${default=4 mem} or, even worse, something with select_first

We often have inputs that are derived (e.g. e) and we do not want these exposed in wdltool inputs ....

I do not have a good idea for how to handle f. I'm assuming you do not have access to the raw expression when rendering wdltool inputs ..., so can you just say that it has a complex default expression?

@Redmar-van-den-Berg

This comment has been minimized.

Copy link

commented Sep 26, 2017

Not to hijack this issue, but would it be possible to put the actual default values in the .json file? Right now, users can change an optional value, but it is very hard to figure out what the default value is. Simply putting it in the json file would save users a lot of hunting through .wdl files to figure out what a sensible value is.

@geoffjentry

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@cjllanwarne what's the current situation here? This is an old enough ticket that it might just work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.