Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Keep relevant Jes metadata events #1304
Conversation
ruchim
added the
in review
label
Aug 18, 2016
ruchim
assigned mcovarr and cjllanwarne
Aug 18, 2016
|
|
mcovarr
commented on an outdated diff
Aug 18, 2016
.../src/main/scala/cromwell/engine/backend/jes/Run.scala
| @@ -119,13 +119,16 @@ object Run { | ||
| } toSeq | ||
| } else Seq.empty | ||
| + val acceptableEvents = Set("start", "pulling-image", "localizing-files", "running-docker", "delocalizing-files", "ok", "fail", "start-shutdown") |
mcovarr
Contributor
|
mcovarr
commented on an outdated diff
Aug 18, 2016
.../src/main/scala/cromwell/engine/backend/jes/Run.scala
| @@ -119,13 +119,16 @@ object Run { | ||
| } toSeq | ||
| } else Seq.empty | ||
| + val acceptableEvents = Set("start", "pulling-image", "localizing-files", "running-docker", "delocalizing-files", "ok", "fail", "start-shutdown") | ||
| + val filteredEventsList: Seq[EventStartTime] = { eventsList filter { i => acceptableEvents.contains(i.name) } } |
|
|
|
|
cjllanwarne
assigned ruchim and unassigned mcovarr and cjllanwarne
Aug 18, 2016
cjllanwarne
added ⭐ Two Thumbs-Up ⭐ Back With Originator ♻️
labels
Aug 18, 2016
mcovarr
commented on an outdated diff
Aug 18, 2016
.../src/main/scala/cromwell/engine/backend/jes/Run.scala
| @@ -26,6 +26,7 @@ object Run { | ||
| lazy val MaximumPollingInterval = Duration(ConfigFactory.load.getConfig("backend").getConfig("jes").getInt("maximumPollingInterval"), "seconds") | ||
| val InitialPollingInterval = 5 seconds | ||
| val PollingBackoffFactor = 1.1 | ||
| + val acceptableEvents = Set("start", "pulling-image", "localizing-files", "running-docker", "delocalizing-files", "ok", "fail", "start-shutdown") |
|
|
ruchim
merged commit 42b47c1
into
0.19_hotfix
Aug 18, 2016
ruchim
removed the
in review
label
Aug 18, 2016
ruchim
deleted the
rm_jesEvents branch
Aug 18, 2016
mbookman
commented on the diff
Sep 2, 2016
.../test/scala/cromwell/engine/backend/jes/RunSpec.scala
| x.startTime.getMillis should be (new DateTime("2015-12-05T00:00:01.000Z").getMillis) | ||
| x.endTime.getMillis should be (new DateTime("2015-12-05T00:01:00.000Z").getMillis) | ||
| } | ||
| + } | ||
| + | ||
| + "JES Run" should "not parse unwated events from Operation metadata" in { |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ruchim commentedAug 18, 2016
Creating a list of acceptable events and filtering the rest out of Jes metadata.