Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Doc section on "security by sysadmin" #1653
Conversation
delocalizer
changed the title from
* section on "security by sysadmin" to * doc section on "security by sysadmin"
Nov 8, 2016
kcibul
assigned geoffjentry and katevoss
Nov 8, 2016
|
Thanks for the contribution! @katevoss @geoffjentry can we get a quick review? |
kcibul
changed the title from
* doc section on "security by sysadmin" to Doc section on "security by sysadmin"
Nov 8, 2016
kcibul
added the
UserSupport ❤️
label
Nov 8, 2016
kcibul
added this to the
Q4 User Driven Development (& Bug Fixes)
milestone
Nov 8, 2016
|
IMO if we put any security recommendations in our README we should be very careful to disclaimer it. Heavily. Maybe with something along the lines of:
|
| @@ -64,6 +66,9 @@ A [Workflow Management System](https://en.wikipedia.org/wiki/Workflow_management | ||
| * [Logging](#logging) | ||
| * [Workflow Options](#workflow-options) | ||
| * [Call Caching](#call-caching) | ||
| + * [Configuring Call Caching](#configuring-call-caching) | ||
| + * [Call Caching Workflow Options](#call-caching-workflow-options) | ||
| + * [Local Filesystem Options](#local-filesystem-options) |
| +# Security | ||
| + | ||
| +Cromwell running in server mode accepts all connections on the configured webservice port. The simplest way to restrict access is by putting an authenticating proxy server in between users and the cromwell server: | ||
| + 1. Configure a firewall rule on the cromwell server host to deny access to the webservice port (e.g. 8000) from all addresses except a secure proxy host. "Secure" here meaning administrator login access only. |
| + | ||
| +Cromwell running in server mode accepts all connections on the configured webservice port. The simplest way to restrict access is by putting an authenticating proxy server in between users and the cromwell server: | ||
| + 1. Configure a firewall rule on the cromwell server host to deny access to the webservice port (e.g. 8000) from all addresses except a secure proxy host. "Secure" here meaning administrator login access only. | ||
| + 1. Configure `<YourFavoriteWebProxy>` on the proxy host with `<YourFavouriteAuthMechanism>`, to proxy authenticated traffic from the world to the cromwell server. Using Apache `httpd` web server for example with basic htpassword file-based authentication, the configuration might look something like: |
mcovarr
Nov 8, 2016
Contributor
The Cromwell team favors
delocalizer
Nov 8, 2016
Contributor
Yeah, my fingers automatically type the Australian (English) sp, I noticed the first one and fixed for you; the second one escaped me :)
|
I'm with @cjllanwarne in favouring some form of disclaimer on this, wanting as little as you to be or feel actually responsible for others' security! |
|
@delocalizer Just so it doesn't seem like I'm being lazy, I wanted to chime in on some of the stuff this has brought up (e.g. the disclaimer) but wanted to chat w/ @katevoss first and we just haven't been able to be mutually free yet today. Worst case it'll happen tomorrow and we can get everything sorted. Thanks for doing this though, now I'll have to actually make good on my side of the deal ;) |
|
Discussed with @katevoss - as we don't have our long range documentation plan hashed out yet for now we'll be:
@delocalizer ... I don't want to make extra work for you here. If you wanted to update this PR to reflect the first and third bullet points great, otherwise I can pick up this PR and do first and third while i'm doing the second. If you're going with the former hold off until I confirm the name of the file :) |
|
Discussed name of the file with @katevoss and we're going to go with |
delocalizer
added some commits
Nov 9, 2016
|
This is great, thanks @delocalizer ! The downside of you doing those followups is that now I don't have the open PR staring me in the face reminding me I have to do something ;) I'll try to put in some content re Firecloud in the near future. |
delocalizer commentedNov 8, 2016
As per discussion on gitter https://gitter.im/broadinstitute/cromwell?at=5818fee6806316005de7615c