Only gzip metadata if requested. Closes #2419 #2427

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
Member

geoffjentry commented Jul 6, 2017

No description provided.

@geoffjentry geoffjentry Only gzip metadata if requested. Closes #2419
25cd481
@mcovarr

mcovarr approved these changes Jul 7, 2017

CHANGELOG.md
@@ -5,6 +5,7 @@
### Breaking Changes
* Request timeouts for HTTP requests on the REST API now return a 503 status code instead of 500. The response for a request timeout is no longer in JSON format.
+* The metadata endpoint was defaulting to responding with a gzipped response. This now needs to be explicitly requested with an `Accept-Encoding: gzip` header
@mcovarr

mcovarr Jul 7, 2017

Contributor

Maybe "no longer returns gzipped responses by default."

+ Get(s"/workflows/$version/${CromwellApiServiceSpec.ExistingWorkflowId}/metadata") ~>
+ akkaHttpService.routes ~>
+ check {
+ response.headers.find(x => x.name() == "Content-Encoding") shouldBe None
@mcovarr

mcovarr Jul 7, 2017

Contributor

_.name() here and above

@kshakir

kshakir Jul 7, 2017

Contributor

Edit: _.name

Contributor

mcovarr commented Jul 7, 2017 edited by briandmaher

👍

Approved with PullApprove

Contributor

kshakir commented Jul 7, 2017 edited by briandmaher

👍 With Miguel's comments

Approved with PullApprove

@geoffjentry geoffjentry code review
68b62a3

@geoffjentry geoffjentry merged commit 644967d into develop Jul 7, 2017

4 checks passed

code-review/pullapprove Approved by kshakir, mcovarr
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 67.492%
Details

geoffjentry deleted the jg_gzip_as_requested branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment