Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add restrict-metadata-access #2435
Conversation
geoffjentry
added some commits
Jul 11, 2017
|
geoffjentry |
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
code-review/pullapprove
— Approval required by 2 of: cjllanwarne, danbills, francares, gauravs90, Horneth, jainh, jsotobroad, katevoss, kcibul, kshakir, mcovarr, ruch
|
58348eb
|
||
|
|
geoffjentry |
All checks have passed |
e5da338
|
mcovarr
self-assigned this
Jul 12, 2017
|
|
| @@ -46,6 +47,14 @@ class JesAttributesSpec extends FlatSpec with Matchers { | ||
| jesAttributes.computeServiceAccount should be("testing") | ||
| } | ||
| + it should "parse restrict-metadata-access" taggedAs IntegrationTest in { | ||
| + val backendConfig = ConfigFactory.parseString(configString(genomics = """restrict-metadata-access = true """)) |
geoffjentry
Jul 12, 2017
Member
This is either copy/paste or intellij. will look and modify as appropriate.
|
|
| @@ -76,6 +78,7 @@ object JesAttributes { | ||
| val maxPollingInterval: Int = backendConfig.as[Option[Int]]("maximum-polling-interval").getOrElse(600) | ||
| val computeServiceAccount: String = backendConfig.as[Option[String]]("genomics.compute-service-account").getOrElse("default") | ||
| val genomicsAuthName: ErrorOr[String] = validate { backendConfig.as[String]("genomics.auth") } | ||
| + val genomicsRestrictMetadataAccess: ErrorOr[Boolean] = validate { backendConfig.as[Option[Boolean]]("genomics.restrict-metadata-access").getOrElse(false) } |
|
|
|
|
geoffjentry |
All checks have passed |
9c1d6f7
|
geoffjentry
merged commit 2862235
into
develop
Jul 12, 2017
geoffjentry
added a commit
that referenced
this pull request
Jul 12, 2017
|
|
geoffjentry + geoffjentry |
9c9b743
|
mcovarr
deleted the
jg_restrict_metadata branch
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
geoffjentry commentedJul 11, 2017
One could argue that "auth file" is now a misnomer, but I rationalized my laziness for maintaining the name in that this relates to auth. Up to you all.