Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize instrumentation with the actor #4402

Merged
merged 2 commits into from Nov 19, 2018

Conversation

Horneth
Copy link
Contributor

@Horneth Horneth commented Nov 17, 2018

Instrumentation was scheduled on a timer out of band of the actor's thread, and in some cases accessing non thread safe state inside the actor (in a read only fashion but still it can cause incoherent values: https://stackoverflow.com/questions/37690525/multiple-threads-checking-map-size-and-conccurency)
Instead use messages to self to schedule instrumentation on the actor's thread

@geoffjentry
Copy link
Contributor

@Horneth out of curiosity, how did you discover this?

@Horneth
Copy link
Contributor Author

Horneth commented Nov 19, 2018

I was looking for an explanation as to why the values in Grafana sometimes are really weird (I've seen the number of running jobs/workflows double and then go back and then double again within a few minutes without any real explanation).
So I looked at the code and this seemed to potentially explain this behavior

@geoffjentry
Copy link
Contributor

@Horneth are you talking about the weird metadata stuff you were spotting or something else?

@Horneth
Copy link
Contributor Author

Horneth commented Nov 19, 2018

@geoffjentry something else, like this:
screen shot 2018-11-19 at 4 55 25 pm

@Horneth Horneth merged commit bde505a into develop Nov 19, 2018
@Horneth Horneth deleted the tj-synchronize-instrumentation branch December 12, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants