AJ-916 Clean up shared CBAS-WDS helm logic for standalone WDS #237
Conversation
coa-helm/templates/cbas-ui.yaml
Outdated
| "cromwellUrlRoot" : "{{ .Values.relay.path }}/cromwell", | ||
| "wdsUrlRoot" : "{{ .Values.relay.path }}/wds", | ||
| "wdsInstanceId" : "{{ .Values.persistence.workspaceManager.workspaceId }}" | ||
| "cromwellUrlRoot" : "{{ .Values.relay.path }}/cromwell" |
There was a problem hiding this comment.
I think cbas will still need these wds values in order to communicate with it.
There was a problem hiding this comment.
I wasnt sure if the .Values.relay.path is still the right url root? after digging around I guess the url hasnt changes, just something else is deploying it, but in this context I guess I am not quite sure if it is safe to assume that Values.relay and Values.ingess are going to have the right path for wds now that the charts are decoupled?
There was a problem hiding this comment.
Hopefully CBAS is ensuring that the right URL is being passed no matter where WDS is coming from - I think in this ticket but you can check with them if you're not sure.
cromwell-helm/templates/cbas-ui.yaml
Outdated
| "cromwellUrlRoot" : "{{ .Values.ingress.path }}/cromwell", | ||
| "wdsUrlRoot" : "{{ .Values.ingress.path }}/wds", | ||
| "wdsInstanceId" : "{{ .Values.persistence.workspaceManager.workspaceId }}" | ||
| "cromwellUrlRoot" : "{{ .Values.ingress.path }}/cromwell" |
|
Other than @calypsomatic comments -- this LGTM |
Clean up to enable standalone WDS, ticket link here.
wds chart now will live here: https://github.com/broadinstitute/terra-helmfile/tree/master/charts/wds