Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read filter for unmapped reads and their mates #5826

Merged
merged 1 commit into from Mar 22, 2019
Merged

Conversation

meganshand
Copy link
Contributor

This read filter removes unnmapped reads and reads with unmapped mates. When used in combination with MateOnSameContigOrNoMappedMateReadFilter this subsets down to reads only on chrM whose mate is also on chrM. If we only used the MateOnSameContigOrNoMappedMateReadFilter we end up with reads whose mate is unmapped still in the BAM, but not the unmapped read, which causes problems downstream in the mitochondria pipeline. This read filter will make the subsetting step faster when we no longer need the NuMTs.

I would really appreciate this getting in before the next release (on Tuesday). (fyi @droazen) @ldgauthier @jsotobroad

@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #5826 into master will increase coverage by <.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5826      +/-   ##
============================================
+ Coverage     87.04%   87.04%   +<.01%     
- Complexity    32153    32155       +2     
============================================
  Files          1975     1975              
  Lines        147415   147426      +11     
  Branches      16225    16226       +1     
============================================
+ Hits         128315   128329      +14     
+ Misses        13185    13181       -4     
- Partials       5915     5916       +1
Impacted Files Coverage Δ Complexity Δ
...nder/engine/filters/ReadFilterLibraryUnitTest.java 100% <100%> (ø) 59 <1> (+1) ⬆️
...e/hellbender/engine/filters/ReadFilterLibrary.java 94.56% <66.66%> (-0.95%) 1 <0> (ø)
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+10%) 3% <0%> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2b5a2...e5bcca0. Read the comment docs.

Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meganshand meganshand merged commit a980ec6 into master Mar 22, 2019
@meganshand meganshand deleted the ms_read_filter branch March 22, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants