Fixes needed to run tutorial #26

Merged
merged 1 commit into from Feb 3, 2016
Jump to file or symbol
Failed to load files and symbols.
+7 −2
Split
View
@@ -166,6 +166,7 @@ Currently the `hello` task returns a `File` with the greeting in it, but what if
```wdl
task hello {
+ String str
command {
echo 'hello ${name}!'
}
@@ -198,10 +199,10 @@ So far we've only been dealing with the standard output of a command, but what i
```wdl
task hello {
command {
- echo 'hello ${name}!'
+ echo 'hello ${name}!' > test.out
}
output {
- String response = read_string(stdout())
+ String response = read_string("test.out")
@scottfrazer

scottfrazer Feb 2, 2016

Contributor

This change raised an eyebrow... I'm pretty sure it should work the way it was originally. I'll take a look. Did you change this because it was broken for you or because you preferred this style over what was there?

@denis-yuen

denis-yuen Feb 2, 2016

Contributor

I wasn't sure, but thought maybe that was the intent of the section. It looked like the example under modifying-task-outputs was precisely the same as referencing-files-on-disk, so I thought maybe there was a copy-paste error and a change like that was intended to demonstrate referencing files on disk.

@scottfrazer

scottfrazer Feb 2, 2016

Contributor

I see, well thanks for this contribution! I'll merge soon

}
}
@@ -253,6 +254,7 @@ Sometimes, an output file is named as a function of one of its inputs.
```wdl
task hello {
+ String name
command {
echo 'hello ${name}!' > ${name}.txt
}
@@ -274,6 +276,7 @@ Say we wanted to call the `hello` task twice. Simply adding two `call hello` st
```wdl
task hello {
+ String name
command {
echo 'hello ${name}!'
}
@@ -358,6 +361,8 @@ What if we wanted to parameterize the greeting and make it used for all invocati
```wdl
task hello {
+ String salutation
+ String name
command {
echo '${salutation}, ${name}!'
}