Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Create GATK wrapper which includes a workflow for each WDL #63
Conversation
knoblett
self-assigned this
Oct 4, 2016
knoblett
added the
in review
label
Oct 4, 2016
|
Wouldn't hurt to have single-tool WDLs for all the tools in wrappers/gatk/. However I wouldn't name the script (or the workflows) Firecloud anything since they're not really specific to firecloud; they can be used on any platform. |
knoblett
added some commits
Oct 6, 2016
knoblett
changed the title from
Create Firecloud-specific GATK wrapper to Create GATK wrapper which includes a workflow for each WDL
Oct 6, 2016
|
Files added and updated. Back to you @vdauwera |
|
OK, a few nitpicks/suggestions:
|
|
@knoblett Quick ping -- is this still on your radar? No rush, just checking that you're not waiting on me here. |
|
It was on hold until Firecloud had implemented arrays, since this PR was for that. Alternatively, if you'd like I can go through it now and merge. I can't remember if I had applied your previously suggested changes or not before this got put on the backburner, but I can check and apply them if needed. |
|
Oh I see, I had forgotten about that. Well, this could actually be useful beyond just FireCloud, so let's go ahead and finalize it (when you have time away from the workshop of course). |
|
bump We'll also want to generate a set for 3.7 |
knoblett commentedOct 4, 2016
After quite a few iterations, this ended up being the simplest solution-- to add a workflow-writing section to the original gatkToWdlWrapper.py in order for it to be used on Firecloud. (Firecloud requires a workflow section in order for the files to be uploaded.)
Is it worthwhile to post the WDL files generated using this script? Or just contact the Firecloud team and get those uploaded to their repository?